https://bugzilla.redhat.com/show_bug.cgi?id=1048040 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Lubomir Rintel <lkundrak@xxxxx> --- 0.) You may want to use a bcond here; so that it's a bit more readable and rpmbuild --without works: # define to build docs, need to undef this for bootstrapping %define docs 1 ... %if 0%{?docs} %bcond_without docs ... %if %with docs 1.) You may want to %exclude this one: qt5-qtserialport-doc.noarch: E: zero-length /usr/share/doc/qt5/qtserialport/demos-manifest.xml * Package is named correctly * Packaging the latest version * Good license, full text present * License tag correct * Rpmlint mostly happy (see above) * Requires file * Provides fine * Filelist fine * SPEC file clean and legible, fairly standard Qt5 package APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review