[Bug 924682] Review Request: gimp-elsamuko - Elsamukos script collection for the GIMP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=924682



--- Comment #10 from Palle Ravn <ravnzon@xxxxxxxxx> ---
(In reply to Christopher Meng from comment #8)
> > > 2. %{_datarootdir} -> %{_datadir}
> > 
> > Done.
> 
> Done?
> 
> %{_datarootdir}/gimp/2.0/scripts/*.scm

I missed that one, sorry for that.

> > > 4. If you don't have any special need, you should remove threaded blank
> > > lines.
> > 
> > It's a topic for endless debate. I use 2 empty lines in all my SPEC files,
> > and I will continue doing so. "All RPM sections, starting from %description,
> > should be separated by two empty lines." -cite
> > http://fedoraproject.org/wiki/PeterGordon/SpecFormattingGuidelines
> > 
> > The new SPEC and RPM files are hosted at gimp-elsamuko.zom.dk
> 
> Peter is not god or standard as far as I know. But I never force you to
> change the style, I only wanted you to remove these:
> 
> Source0:        https://sites.google.com/site/elsamuko/gimp/elsamuko.zip
> 
> Requires:       gimp
> 
> BuildArch:      noarch
> 
> --------------->
> Source0:        https://sites.google.com/site/elsamuko/gimp/elsamuko.zip
> Requires:       gimp
> BuildArch:      noarch
> 
> ----------------

I misunderstood that one. I will remove the empty lines.

> Please remember to add COPYING file as %doc when upstream releases new
> tarball. *This is a MUST*.

I made a comment in the %files section to remember this.

(In reply to Christopher Meng from comment #9)
> Also, it's better to leave a blank line between each changelog.

I will start doing that.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]