https://bugzilla.redhat.com/show_bug.cgi?id=1047497 --- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: otcl. Illegal package name: otcl. Does not provide -static: otcl. See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck: Unknown or generated -------------------- otcl-1.14/otcl.c otcl-1.14/otcl.h otcl-1.14/otclAppInit.c otcl-1.14/otkAppInit.c ---> Tell upstream. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/debug/.build-id/b4(gcc- debuginfo, glibc-debuginfo), /usr/lib/debug/usr/bin(gcc-debuginfo, sqlite-debuginfo, glibc-debuginfo-common, ncurses-debuginfo, lnav- debuginfo, bzip2-debuginfo, pcre-debuginfo, openssl-debuginfo), /usr/lib/debug/.build-id(readline-debuginfo, sqlite-debuginfo, glibc- debuginfo-common, gcc-base-debuginfo, gcc-debuginfo, glibc-debuginfo, zlib-debuginfo, ncurses-debuginfo, lnav-debuginfo, bzip2-debuginfo, pcre- debuginfo, openssl-debuginfo), /usr/lib/debug/.dwz(readline-debuginfo, sqlite-debuginfo, zlib-debuginfo, ncurses-debuginfo, bzip2-debuginfo, pcre-debuginfo, openssl-debuginfo), /usr/lib/debug(readline-debuginfo, sqlite-debuginfo, glibc-debuginfo-common, gcc-base-debuginfo, gcc- debuginfo, glibc-debuginfo, zlib-debuginfo, ncurses-debuginfo, lnav- debuginfo, bzip2-debuginfo, filesystem, pcre-debuginfo, openssl- debuginfo), /usr/lib/debug/usr(gcc-debuginfo, sqlite-debuginfo, glibc- debuginfo-common, gcc-base-debuginfo, glibc-debuginfo, zlib-debuginfo, ncurses-debuginfo, lnav-debuginfo, bzip2-debuginfo, filesystem, pcre- debuginfo), /usr/lib/debug/.build-id/73(gcc-debuginfo), /usr/lib/debug/usr/lib(readline-debuginfo, sqlite-debuginfo, gcc-base- debuginfo, gcc-debuginfo, glibc-debuginfo, zlib-debuginfo, ncurses- debuginfo, bzip2-debuginfo, pcre-debuginfo, openssl-debuginfo), /usr/lib/debug/.build-id/eb(glibc-debuginfo) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 296960 bytes in 9 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in otcl-devel , otcl-docs ---> Please add _isa in -devel sub. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: otcl-1.14-2.fc21.i686.rpm otcl-devel-1.14-2.fc21.noarch.rpm otcl-docs-1.14-2.fc21.noarch.rpm otcl-1.14-2.fc21.src.rpm otcl.i686: W: unstripped-binary-or-object /usr/lib/debug/.dwz/otcl-1.14-2.fc21.i386 otcl.i686: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/otclsh.debug otcl.i686: E: statically-linked-binary /usr/lib/debug/usr/bin/otclsh.debug otcl.i686: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/owish.debug otcl.i686: E: statically-linked-binary /usr/lib/debug/usr/bin/owish.debug otcl.i686: W: no-soname /usr/lib/libotcl.so otcl.i686: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/libotcl.so.debug otcl.i686: E: shared-lib-without-dependency-information /usr/lib/debug/usr/lib/libotcl.so.debug otcl.i686: W: hidden-file-or-dir /usr/lib/debug/.dwz otcl.i686: W: hidden-file-or-dir /usr/lib/debug/.dwz otcl.i686: W: hidden-file-or-dir /usr/lib/debug/.build-id otcl.i686: W: hidden-file-or-dir /usr/lib/debug/.build-id otcl.i686: W: devel-file-in-non-devel-package /usr/lib/libotcl.a otcl.i686: W: spurious-executable-perm /usr/lib/libotcl.a otcl.i686: E: library-without-ldconfig-postin /usr/lib/debug/usr/lib/libotcl.so.debug otcl.i686: E: library-without-ldconfig-postun /usr/lib/debug/usr/lib/libotcl.so.debug ---> debuginfo can't be found, Why did you mark -devel as noarch: BuildArch: noarch??? otcl.i686: W: no-manual-page-for-binary otclsh otcl.i686: W: no-manual-page-for-binary owish otcl-devel.noarch: W: no-documentation otcl.src: W: strange-permission otcl-src-1.14.tar.gz 0640L otcl.src:73: W: mixed-use-of-spaces-and-tabs (spaces: line 73, tab: line 9) 4 packages and 0 specfiles checked; 5 errors, 16 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint otcl otcl-devel otcl-docs otcl.i686: W: unstripped-binary-or-object /usr/lib/debug/.dwz/otcl-1.14-2.fc21.i386 otcl.i686: W: ldd-failed /usr/lib/debug/.dwz/otcl-1.14-2.fc21.i386 otcl.i686: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/otclsh.debug otcl.i686: E: statically-linked-binary /usr/lib/debug/usr/bin/otclsh.debug otcl.i686: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/owish.debug otcl.i686: E: statically-linked-binary /usr/lib/debug/usr/bin/owish.debug otcl.i686: W: no-soname /usr/lib/libotcl.so otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_AppendResult otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_UpVar2 otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_DeleteHashTable otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_NewStringObj otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_GetString otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_StringMatch otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_SetVar2 otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_GetCommandName otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_DeleteCommandFromToken otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_Free otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_InitHashTable otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_ResetResult otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so TclFreeObj otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_ProcObjCmd otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_Eval otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_GetVar2 otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_FirstHashEntry otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_SplitList otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_NextHashEntry otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_DeleteCommand otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_SetResult otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_UnsetVar2 otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_FindCommand otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_DeleteHashEntry otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_AddObjErrorInfo otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_CreateCommand otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_AppendElement otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_GetCommandInfo otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_VarEval otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_Alloc otcl.i686: W: undefined-non-weak-symbol /usr/lib/libotcl.so Tcl_CreateNamespace otcl.i686: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/libotcl.so.debug otcl.i686: E: shared-lib-without-dependency-information /usr/lib/debug/usr/lib/libotcl.so.debug otcl.i686: W: hidden-file-or-dir /usr/lib/debug/.dwz otcl.i686: W: hidden-file-or-dir /usr/lib/debug/.dwz otcl.i686: W: hidden-file-or-dir /usr/lib/debug/.build-id otcl.i686: W: hidden-file-or-dir /usr/lib/debug/.build-id otcl.i686: W: devel-file-in-non-devel-package /usr/lib/libotcl.a otcl.i686: W: spurious-executable-perm /usr/lib/libotcl.a otcl.i686: E: library-without-ldconfig-postin /usr/lib/debug/usr/lib/libotcl.so.debug otcl.i686: E: library-without-ldconfig-postun /usr/lib/debug/usr/lib/libotcl.so.debug otcl.i686: W: no-manual-page-for-binary otclsh otcl.i686: W: no-manual-page-for-binary owish otcl-devel.noarch: W: no-documentation 3 packages and 0 specfiles checked; 5 errors, 46 warnings. # echo 'rpmlint-done:' Requires -------- otcl (rpmlib, GLIBC filtered): libX11.so.6 libc.so.6 libdl.so.2 libm.so.6 libnsl.so.1 libtcl8.5.so libtk8.5.so rtld(GNU_HASH) otcl-devel (rpmlib, GLIBC filtered): otcl otcl-docs (rpmlib, GLIBC filtered): otcl Provides -------- otcl: libotcl.so otcl otcl(x86-32) otcl-devel: otcl-devel otcl-docs: otcl-docs Unversioned so-files -------------------- otcl: /usr/lib/libotcl.so Source checksums ---------------- http://downloads.sourceforge.net/project/otcl-tclcl/OTcl/1.14/otcl-src-1.14.tar.gz : CHECKSUM(SHA256) this package : c644aed47ccd7e082ad47388dc8a2412a0eceacbe81d8574e560a797b782b969 CHECKSUM(SHA256) upstream package : c644aed47ccd7e082ad47388dc8a2412a0eceacbe81d8574e560a797b782b969 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn otcl-1.14-2.oji.fc19.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: BATCH, EPEL5, EXARCH, DISTTAG -------------------- SPEC part: 1. Please avoid this kind of style, weird, no appropriate reason to leave it there: %description docs %common_desc Please improve it, don't be lazy. 2. %configure --prefix=%_prefix Please eval the %configure macro, default should cover the option. 3. Request a license from upstream. 4. Why keep .a files? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review