https://bugzilla.redhat.com/show_bug.cgi?id=924682 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to Palle Ravn from comment #7) > (In reply to Christopher Meng from comment #6) > > 1. You need to request a license file from upstream and ship it in the > > tarball > > I have emailed Samuel Elsamuko and awaiting his response. Fine. > > 2. %{_datarootdir} -> %{_datadir} > > Done. Done? %{_datarootdir}/gimp/2.0/scripts/*.scm > > 4. If you don't have any special need, you should remove threaded blank > > lines. > > It's a topic for endless debate. I use 2 empty lines in all my SPEC files, > and I will continue doing so. "All RPM sections, starting from %description, > should be separated by two empty lines." -cite > http://fedoraproject.org/wiki/PeterGordon/SpecFormattingGuidelines > > The new SPEC and RPM files are hosted at gimp-elsamuko.zom.dk Peter is not god or standard as far as I know. But I never force you to change the style, I only wanted you to remove these: Source0: https://sites.google.com/site/elsamuko/gimp/elsamuko.zip Requires: gimp BuildArch: noarch ---------------> Source0: https://sites.google.com/site/elsamuko/gimp/elsamuko.zip Requires: gimp BuildArch: noarch ---------------- PACKAGE APPROVED. Please remember to add COPYING file as %doc when upstream releases new tarball. *This is a MUST*. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review