https://bugzilla.redhat.com/show_bug.cgi?id=1046513 --- Comment #3 from František Dvořák <valtri@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #2) > > Issues: > ======= > [x] Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files directly in %_libdir. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages > [?] ldconfig called in %post and %postun if required. > Note: /sbin/ldconfig not called in glite-lb-state-machine-plugins > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries > > I assume these libs are private, right? > Basically yes. One library is "normal" (the glite-lb-state-machine package) and the other is a plugin (private library loaded at runtime, the glite-lb-state-machine-plugins package). > > Unknown or generated > -------------------- > glite-lb-state-machine-2.0.7/interface/intjobstat_supp.h > glite-lb-state-machine-2.0.7/src/intjobstat_supp.c > glite-lb-state-machine-2.0.7/src/job_attrs.xsl > glite-lb-state-machine-2.0.7/src/job_attrs2.xsl > glite-lb-state-machine-2.0.7/src/jpis_config.xsl > > ---> Since you are the upstream maintainer, please add license header > later(not a blocker of this review.) > OK. > > Rpmlint (installed packages) > ---------------------------- > # rpmlint glite-lb-state-machine-plugins glite-lb-state-machine > glite-lb-state-machine-devel > glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol > /usr/lib/glite_lb_plugin.so.0.0.0 glite_jppsbe_append_tags > glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol > /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_attrval_free > glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol > /usr/lib/glite_lb_plugin.so.0.0.0 glite_jppsbe_pread > glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol > /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_clear_error > glite-lb-state-machine-plugins.i686: W: undefined-non-weak-symbol > /usr/lib/glite_lb_plugin.so.0.0.0 glite_jp_stack_error > > -----> Are they caused by unreleased dependencies? > Yes, these symbols are provided by the code using the plugin. It is used in glite-lb-utils package for example (not yet submitted for review). > [rpmaker@fab Desktop]$ ldd -r > ~/Desktop/glite-lb-state-machine/results/usr/lib/libglite_lb_statemachine.so > linux-gate.so.1 => (0xb7774000) > libglite_lb_common.so.16 => not found > libglite_security_gss.so.9 => not found > libglite_jobid.so.2 => not found > libc.so.6 => /lib/libc.so.6 (0xb756b000) > /lib/ld-linux.so.2 (0xb7775000) The missing libraries looks wrong, but I guess the ldd were just called on extracted library here and rpms were not installed. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review