https://bugzilla.redhat.com/show_bug.cgi?id=1046121 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Must: [!]: Package does not generate any conflict. Conflicts: php-pear(pear.doctrine-project.org/DoctrineCommon) < 2.4 This is ok, buth worth a comment to explain this is a split-off DoctrineCommon [!]: Dist tag is present (not strictly required in GL). Please use %{?dist} Cosmetic: [!]: %check is present and all tests pass. Also remove tests/Doctrine/Tests/Common/Cache/CouchbaseCacheTest.php which fails when couchbase extension is installed About the sub-package, I don't know what is better, to say "If you wand memcached handler, you need to install: - php-doctrine-cache-memcached (will pull php-pecl-memcached) OR only - php-pecl-memcached Both are acceptable, first is perhaps more confusing for user. I think you will have an issue when pecl/riak or pecl/couchbase will come to fedora repo (already in my repo, but not ready for review, mostly because of bundled lib) as you will have to move the file from main package to a new sub-package ? (this could create upgrade issue for users) So perhaps it will be simpler to keep all the handlers in the main package. This stay your packager choice. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review