[Bug 1047599] Review Request: php-phpseclib-Math-BigInteger - Pure-PHP arbitrary precision integer arithmetic library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1047599



--- Comment #5 from Adam Williamson <awilliam@xxxxxxxxxx> ---
All of these come from pear make-rpm-spec, so we should probably fix that for
the future.

I disagree with Shawn's first suggestion:

%files should be:

%dir %{pear_phpdir}/Math
%{pear_phpdir}/Math/BigInteger.php

There is no difference between ours except mine is simpler. In both cases the
package owns /usr/share/pear/Math and /usr/share/pear/Math/BigInteger.php .

As long as there isn't a 'php-filesystem' package or something to own 'shared'
namespaces like /usr/share/pear/Crypt , /usr/share/pear/Math etc, packages have
no good choice, only three bad ones:

(bad) Own the directory, violating the guideline
(worse) Don't own the directory, and require a package that's completely
unrelated and not required at all to ensure that *something* owns the directory
(worse?) Don't own the directory and don't require any other package, leaving
the directory unowned unless one of the other packages that happens to own the
directory is installed

In any case, both my current version and Shawn's suggestion implement the first
of these.

I'll go through and clean the other stuff. Who wants to fix pear make-rpm-spec
? :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]