https://bugzilla.redhat.com/show_bug.cgi?id=1012391 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #28 from Michael Schwendt <bugs.michael@xxxxxxx> --- * Indeed, the 25K diff between 0.5.2 and 0.5.3 drops the bundled MD5. * fedora-review complains about missing parallel make macro, but that's only because of the extra "doc" make target. That's acceptable. Even if the smp flags were dropped from the first make invocation in %build, that would be acceptable IMO, because there's not much to build. * Related to the "doc" target, a closer look reveals that the top Makefile builds the "doc" subdir target via target "all" already, so the explicit pushd doc make in %build is superfluous. rpmdiff suggests that you've readded that step after the -6 spec release. * Options -e blowfish and -e sha1 are rejected. The man page comments on that, so I only point it out. * No blockers that would justify requesting another update for review. You may fix the minor "make" issue in dist git. APPROVED -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review