https://bugzilla.redhat.com/show_bug.cgi?id=1047599 --- Comment #3 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- ===== MUST items ===== [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/pear/Math(php-pear- Math-Stats) %files should be: %dir %{pear_phpdir}/Math %{pear_phpdir}/Math/BigInteger.php [!]: Package is named according to the Package Naming Guidelines. Even though existing pkgs use CamelCase, we have been trying to adhere to the naming guideline "You should generally use lowercase", so: php-phpseclib-math-biginteger [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Please remove this EPEL 5 piece "rm -rf $RPM_BUILD_ROOT" in %install ===== SHOULD items ===== [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required Please remove this EPEL 5 piece [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Please submit a query to upstream to include a license file and link to it in your spec. [x]: Final provides and requires are sane (see attachments). Please add the following from phpcompatinfo (can be done after initial import; these are already loaded from php-common but we explicitly specify all PHP extension requirements) * php-date * php-pcre Description already mentions optional BCMath (php-bcmath) and GMP (php-gmp) but you should also add a note about optional OpenSSL (php-openssl) [x]: Package does not include license text files separate from upstream. We usually add a LICENSE file while we are waiting for upstream to add one from our request. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review