Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Pyclutter - Python modules that allow you to use the Clutter toolkit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233695 ------- Additional Comments From dcm@xxxxxxx 2007-03-27 21:52 EST ------- Good: - Package meets naming and packaging guidelines - Spec file matches base package name. - Spec has consistant macro usage. - Meets Packaging Guidelines. - Spec in American English - Spec is legible. - Sources match upstream md5sum: cb2565cd0014ccc3f1f2700c8c6f3193 pyclutter-0.2.0.tar.gz - BuildRequires correct - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content. - Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - -devel package Requires: %{name} = %{version}-%{release} - Package compiles and builds on at least one arch. - Package has no duplicate files in %files. - Package doesn't own any directories other packages own. - No rpmlint output. Bad: - COPYING file contains the GPL but spec says LGPL. Which is correct? - Package should own directory %{python_sitearch}/clutter - %changelog should have a blank line after each entry - make install should include INSTALL="%{__install} -p" so that timestamps are preserved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review