https://bugzilla.redhat.com/show_bug.cgi?id=875087 --- Comment #21 from Orion Poplawski <orion@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel You need to have BuildRequires: python2-devel - Please fix the FSF address in the license. - It looks like cluster_status is a GUI application and as such should have a .desktop file. - cluster_status (and perhaps even gen_nodes_file) is too generic. Please add a pbs (or pbs_) prefix. - Drop BuildRoot and %clean unless you want to target epel5 - You only need to define python_sitelib, etc if you want to target epel5. If you do, please use the form from the guidelines: %if 0%{?rhel} && 0%{?rhel} <= 5 %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif - Your changelog versions do not match the package version "0.7" vs "0.7a". - You need to escape "%" in %changelog entries with another %, eg %%clean ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /export/home/orion/redhat/pbsclusterviz-0.7a/875087-pbsclusterviz/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [!]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pbsclusterviz-0.7a-4.fc20.noarch.rpm pbsclusterviz-0.7a-4.fc20.src.rpm pbsclusterviz.noarch: W: incoherent-version-in-changelog 0.7-4 ['0.7a-4.fc20', '0.7a-4'] pbsclusterviz.noarch: E: incorrect-fsf-address /usr/bin/gen_nodes_file pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/clusterviz_config.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/node_grid_display.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/__init__.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/screen_log.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/node.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/bin/cluster_status pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/node_grid_xml_handler.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/node_grid.py pbsclusterviz.noarch: W: no-manual-page-for-binary gen_nodes_file pbsclusterviz.noarch: W: no-manual-page-for-binary cluster_status pbsclusterviz.src:56: W: macro-in-comment %{python_sitelib} pbsclusterviz.src:72: W: macro-in-%changelog %clean pbsclusterviz.src: W: invalid-url Source0: https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz-0.7a.tar.gz HTTP Error 403: Forbidden 2 packages and 0 specfiles checked; 9 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint pbsclusterviz pbsclusterviz.noarch: W: incoherent-version-in-changelog 0.7-4 ['0.7a-4.fc20', '0.7a-4'] pbsclusterviz.noarch: E: incorrect-fsf-address /usr/bin/gen_nodes_file pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/clusterviz_config.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/node_grid_display.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/__init__.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/screen_log.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/node.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/bin/cluster_status pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/node_grid_xml_handler.py pbsclusterviz.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pbsclusterviz/node_grid.py pbsclusterviz.noarch: W: no-manual-page-for-binary gen_nodes_file pbsclusterviz.noarch: W: no-manual-page-for-binary cluster_status 1 packages and 0 specfiles checked; 9 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- pbsclusterviz (rpmlib, GLIBC filtered): /usr/bin/python config(pbsclusterviz) libxml2-python python python(abi) vtk-python Provides -------- pbsclusterviz: config(pbsclusterviz) pbsclusterviz Source checksums ---------------- https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz-0.7a.tar.gz : CHECKSUM(SHA256) this package : d44dbd75ace3302b65a0159c9136fdd74aa621f0e6462f81a534fc34d909a876 CHECKSUM(SHA256) upstream package : 36dee1b626ae824538453e41e7d668e3e44a3f32c416e14faddb00d750278a86 However, diff -r shows no differences Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 875087 Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review