Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: clutter - Open Source software library for creating rich graphical user interfaces https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233691 dcm@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From dcm@xxxxxxx 2007-03-27 12:38 EST ------- Good: - Package meets naming and packaging guidelines - Spec file matches base package name. - Spec has consistant macro usage. - Meets Packaging Guidelines. - License LGPL - License field in spec matches - License file included in package - Spec in American English - Spec is legible. - Sources match upstream md5sum: ee2d38920432eb11172e247c471e195c clutter-0.2.2.tar.gz - BuildRequires correct - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content. - Doc subpackage not needed. - Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package compiles and builds on at least one arch. - Package has no duplicate files in %files. - Package doesn't own any directories other packages own. - Package owns all the directories it creates. - No rpmlint output. - final provides and requires are sane. Bad: - There should be a blank line after each entry in %changelog Please fix that final issue when you commit. This package is: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review