[Bug 1047110] Review Request: php-doctrine-dbal - Doctrine Database Abstraction Layer (DBAL)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1047110



--- Comment #4 from Adam Williamson <awilliam@xxxxxxxxxx> ---
Hum, let me clean that up a bit, it's quite confusing :(

I would suggest we need the following commits beyond what's already in the
spec:

1.
https://github.com/doctrine/dbal/commit/5156391b5686a2b3bba628bb0bc1fece63409a44.patch
"Quote Old column Names when generating ALTER TABLE SQL" (matches OwnCloud "Use
quoted column name for alter table")

2.
https://github.com/doctrine/dbal/commit/e1cd82a50cc9f020b45fe8229afe7c60d3945718.patch
"Fix issue with drop constraint + column ordering in ALTER TABLE of
PostgreSQL." (matches OwnCloud "Dropped indexes can have constraints, drop
those first if they exist")

3.
https://github.com/owncloud/3rdparty/commit/39314855aa5475c016ffae1f747f903db1ee1685.patch
"Add 'bigint unsigned' mapping to Doctrine SqlitePlatform" (appears to have no
upstream pull request)

4. *POSSIBLY*
https://github.com/doctrine/dbal/commit/3da7d2ffec4a90854f2e09f58eef2ff24e5f436a.patch
"Besides the table name, the column name has to be quoted in column comments."
(matches OwnCloud "Use quoted column identifier for adding comment to column",
but OC later reverted that change without explaining why; I added a comment
asking for an explanation)

5.
https://github.com/doctrine/dbal/commit/17edd0d54a16338738274161c422ba5486e2766b.patch
"fix column default value lifecycle" (matches OwnCloud "fix drop default on
postgresql when default value is removed")

I'm going to get in touch with the relevant parties about having as many of the
fixes as possible sent to upstream's 2.4 branch, so we don't need to carry them
downstream all the way up until 2.5...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]