[Bug 1046688] Review Request: netsurf-buildsystem - makefiles shared by NetSurf projects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1046688

David Tardon <dtardon@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtardon@xxxxxxxxxx



--- Comment #2 from David Tardon <dtardon@xxxxxxxxxx> ---
(In reply to Christopher Meng from comment #1)
> Only 2 small issues:
> 
> 1. %build
> You should add a note there for the sake of tell others that nothing need to
> be built.

Does an empty %build section not indicate that quite well already? :-)

> 
> 2. %install
> make install DESTDIR=%{buildroot} PREFIX=/usr
> 
> You should use %{_prefix} instead of simple straightforward "/usr"

I know... I forgot to change it in this one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]