[Bug 1046584] Review Request: libzhuyin - Library to deal with zhuyin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1046584

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:-

+ Package built successfully in mock (rawhide-x86_64)

+ rpmlint on generated rpms gave
libzhuyin.src: W: spelling-error Summary(en_US) zhuyin -> Zhukov
libzhuyin.src: W: spelling-error %description -l en_US zhuyin -> Zhukov
libzhuyin.x86_64: W: spelling-error Summary(en_US) zhuyin -> Zhukov
libzhuyin.x86_64: W: spelling-error %description -l en_US zhuyin -> Zhukov
libzhuyin-data.x86_64: W: only-non-binary-in-usr-lib
libzhuyin-data.x86_64: W: no-documentation
libzhuyin-devel.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 7 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball : aacb7a2a04db2b22380576e27d3118b34f9b6318acbbb6ce25ca962e08a53b59
upstream tarball : 
aacb7a2a04db2b22380576e27d3118b34f9b6318acbbb6ce25ca962e08a53b59

+ License is valid and included as headers in source files as well as COPYING.

Suggestions:
1) To have verbose compilation log use
make V=1 %{?_smp_mflags}

2) preserve timestamps of header files using
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"


APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]