https://bugzilla.redhat.com/show_bug.cgi?id=1040243 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |capnproto-c++ - a data |capnproto-c++ - A data |interchange format and |interchange format and |capability-based RPC system |capability-based RPC system |(sponsor needed) | --- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx> --- * A review ticket blocking the FE-NEEDSPONSOR tracker appears on the page http://fedoraproject.org/PackageReviewStatus/NEEDSPONSOR.html * Keep the spec %summary in sync with the bugzilla ticket Summary, so there won't be any confusion when creating the package in Fedora infrastructure (such as pkgdb). * https://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary_or_Description > This is for capnproto 0.4.0-rc1. The hyphen in the name makes it messy. There are versioning guidelines that would move the "rc1" into the Release tag: https://fedoraproject.org/wiki/Packaging:Guidelines#Version_and_Release https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages A 0.4.0-rc1 would have become Version: 0.4.0 Release: 0.1.rc1%{?dist} instead of Version: 0.4.0-rc1 Release: 1%{?dist} That makes it easier (and more convenient) to update from 0.4.0 pre-releases to 0.4.0 final and also to 0.4.0 post-releases without running into trouble with RPM version comparison. > %doc Empty %doc lines are a no-op and should be deleted. > # Make runs tests, and the tests can't find the just-built libraries when > # rpath is suppressed. Adding the .libs directory to LD_LIBRARY_PATH > # lets the tests pass. > LD_LIBRARY_PATH="`/bin/pwd`/.libs" make %{?_smp_mflags} So far so good, but what about the "check" target? It's missing in the Make invocation and would build and run "354 tests from 42 test cases". Not to be confused with gtest's own test-suite. diff -u capnproto-c++.spec.orig capnproto-c++.spec --- capnproto-c++.spec.orig 2013-12-12 21:23:28.000000000 +0100 +++ capnproto-c++.spec 2013-12-24 12:24:05.937240179 +0100 @@ -52,6 +52,10 @@ find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' +%check +LD_LIBRARY_PATH=$(pwd)/.libs:$(pwd)/gtest/lib/.libs make %{?_smp_mflags} check + + %post -p /sbin/ldconfig %postun -p /sbin/ldconfig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review