Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mcs - A configuration file abstraction library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232342 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-03-27 08:16 EST ------- MUST: ===== 0 rpmlint output is: W: mcs incoherent-version-in-changelog 0.4.1-1.fc7 0.4.1-0.1 W: mcs no-documentation W: mcs-devel no-dependency-on mcs W: mcs-devel no-documentation * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel x86_64 * BR: ok * No locales * ldconfig run for shared libraries * Not relocatable * Package owns / or requires all dirs 0 No duplicate files & Permissions * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * -devel package as needed * no .desktop file required Must FIX ======== * The following rpmlint messages: W: mcs incoherent-version-in-changelog 0.4.1-1.fc7 0.4.1-0.1 W: mcs no-documentation For the docs, add: "%doc AUTHORS COPYING README TODO" * Remove the unnecessart: "Requires(post): /sbin/ldconfig" * Remove msc_config.h and patch the other .h files to not include it -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review