[Bug 1045141] Review Request: python-jsonpath-rw - extended implementation of JSONPath for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1045141



--- Comment #4 from Christopher Meng <cickumqt@xxxxxxxxx> ---
1. Source0:   
https://github.com/kennknowles/python-jsonpath-rw/archive/%version.tar.gz 

->

Source0:   
https://github.com/kennknowles/python-jsonpath-rw/archive/%{version}.tar.gz

2. python-devel -> python2-devel
   %{python_sitelib} -> %{python2_sitelib}

3. Remove:

Provides:       python-jsonpath-rw = %{version}-%{release}

4. python3 package is incorrect packaged, see an example of mine:

http://cicku.me/python-pygit2.spec

You can see that currect spec you provide is questionable:

Processing files: python-jsonpath-rw-1.2.3-1.fc21.noarch
Provides: python-jsonpath-rw = 1.2.3-1.fc21
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix)
<= 4.0-1
Requires: python(abi) = 2.7 python(abi) = 3.3
Checking for unpackaged file(s): /usr/lib/rpm/check-files
/builddir/build/BUILDROOT/python-jsonpath-rw-1.2.3-1.fc21.noarch
warning: Could not canonicalize hostname: buildvm-26.phx2.fedoraproject.org
Wrote: /builddir/build/RPMS/python-jsonpath-rw-1.2.3-1.fc21.noarch.rpm

5. Remove rm -rf $RPM_BUILD_ROOT, we don't need this even on EPEL6.

6. %{python3_sitelib} -> %{python3_sitelib}/*, because this package shouldn't
own this directory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]