[Bug 924682] Review Request: gimp-elsamuko - Elsamukos script collection for the GIMP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=924682



--- Comment #6 from Christopher Meng <cickumqt@xxxxxxxxx> ---
1. You need to request a license file from upstream and ship it in the
tarball(you can ask upstream to regenerate one). Better not add a separate
license file by yourself instead.

2. %{_datarootdir} -> %{_datadir}

3. Add a comment in %build like "Nothing to build" to indicate that no need to
build anything here.

4. If you don't have any special need, you should remove threaded blank lines.

Others are fine.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]