https://bugzilla.redhat.com/show_bug.cgi?id=1020309 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #10 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok license: ok macros: ok sources: ok 96320feda9805296c72e1e10578b903e kdeconnect-kde-0.4.2.tar.xz scriptlets: ok builds/installs/runs: ok 1. MUST: minor issues with dir ownership, these end up unowned: %{_kde4_libdir}/kde4/imports/org/kde/kdeconnect/ %{_kde4_appsdir}/plasma/plasmoids/kdeconnect/ 2. SHOULD: omit extraneous build dep BuildRequires: cmake (already pulled in by kdelibs-devel) Those 2 issues are minor, and can be fixed post import and prior to doing any official builds. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review