https://bugzilla.redhat.com/show_bug.cgi?id=1010512 --- Comment #7 from Will Benton <willb@xxxxxxxxxx> --- Some issues here, but the most serious one is bundling. (It basically doesn't matter that upstream is bundling.) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel You should replace the unversioned python-devel BR with python2-devel or python3-devel as appropriate. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. mesos-devel should own %{includedir}/mesos. Currently stout and libprocess are in there as well, but these probably shouldn't be. [!]: Package must own all directories that it creates. as above [x]: %build honors applicable compiler flags or justifies otherwise. But see below re: smp_mflags [!]: Package contains no bundled libraries without FPC exception. leveldb, stout, and libprocess are all available from separate upstreams (stout and leveldb are already in Fedora). If you can justify exceptions (seems likely for stout and possible for libprocess?), then apply for them; otherwise, mesos will need to be patched to use system copies. Other bundled libraries in 3rdparty should be removed before building. [x]: Changelog in prescribed format. [!]: Sources contain only permissible code or content. as above re: bundled libs [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. Please comment the ExcludeArch with justification. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. not a blocker, but please justify in a spec comment why it isn't there. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. (NB: this is another reason why stout and libprocess shouldn't be bundled) [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Tests skipped due to problems in mock; not a blocker [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Please use %global throughout. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1587200 bytes in /usr/share [x]: Rpmlint is run on all installed packages. NB: Logrotate configuration is really important for a long-running service. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mesos-0.16.0-1.d3557e8.fc20.x86_64.rpm mesos-stout-devel-0.16.0-1.d3557e8.fc20.noarch.rpm mesos-libprocess-0.16.0-1.d3557e8.fc20.x86_64.rpm mesos-libprocess-devel-0.16.0-1.d3557e8.fc20.x86_64.rpm mesos-devel-0.16.0-1.d3557e8.fc20.x86_64.rpm mesos-0.16.0-1.d3557e8.fc20.src.rpm mesos.x86_64: E: missing-call-to-setgroups /usr/lib64/libmesos-0.16.0.so.0.0.0 mesos.x86_64: W: non-conffile-in-etc /etc/sysconfig/mesos/mesos-master-env mesos.x86_64: W: non-conffile-in-etc /etc/sysconfig/mesos/mesos-deploy-env mesos.x86_64: W: non-conffile-in-etc /etc/sysconfig/mesos/mesos-slave-env mesos.x86_64: W: log-files-without-logrotate /var/log/mesos mesos.x86_64: W: no-manual-page-for-binary mesos-stop-slaves.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-cluster.sh mesos.x86_64: W: no-manual-page-for-binary mesos-log mesos.x86_64: W: no-manual-page-for-binary mesos mesos.x86_64: W: no-manual-page-for-binary mesos-local mesos.x86_64: W: no-manual-page-for-binary mesos-start-cluster.sh mesos.x86_64: W: no-manual-page-for-binary mesos-daemon.sh mesos.x86_64: W: no-manual-page-for-binary mesos-slave mesos.x86_64: W: no-manual-page-for-binary mesos-ps mesos.x86_64: W: no-manual-page-for-binary mesos-tail mesos.x86_64: W: no-manual-page-for-binary mesos-master mesos.x86_64: W: no-manual-page-for-binary mesos-start-masters.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-masters.sh mesos.x86_64: W: no-manual-page-for-binary mesos-resolve mesos.x86_64: W: no-manual-page-for-binary mesos-execute mesos.x86_64: W: no-manual-page-for-binary mesos-cat mesos.x86_64: W: no-manual-page-for-binary mesos-start-slaves.sh mesos-libprocess.x86_64: W: one-line-command-in-%post /sbin/ldconfig mesos-devel.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 1 errors, 23 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mesos-libprocess mesos-libprocess-devel mesos-stout-devel mesos-devel mesos mesos-libprocess.x86_64: W: one-line-command-in-%post /sbin/ldconfig mesos-devel.x86_64: W: no-documentation mesos.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmesos-0.16.0.so.0.0.0 /lib64/libhttp_parser.so.2 mesos.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmesos-0.16.0.so.0.0.0 /lib64/libev.so.4 mesos.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmesos-0.16.0.so.0.0.0 /lib64/libz.so.1 mesos.x86_64: E: missing-call-to-setgroups /usr/lib64/libmesos-0.16.0.so.0.0.0 mesos.x86_64: W: non-conffile-in-etc /etc/sysconfig/mesos/mesos-master-env mesos.x86_64: W: non-conffile-in-etc /etc/sysconfig/mesos/mesos-deploy-env mesos.x86_64: W: non-conffile-in-etc /etc/sysconfig/mesos/mesos-slave-env mesos.x86_64: W: log-files-without-logrotate /var/log/mesos mesos.x86_64: W: no-manual-page-for-binary mesos-stop-slaves.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-cluster.sh mesos.x86_64: W: no-manual-page-for-binary mesos-log mesos.x86_64: W: no-manual-page-for-binary mesos mesos.x86_64: W: no-manual-page-for-binary mesos-local mesos.x86_64: W: no-manual-page-for-binary mesos-start-cluster.sh mesos.x86_64: W: no-manual-page-for-binary mesos-daemon.sh mesos.x86_64: W: no-manual-page-for-binary mesos-slave mesos.x86_64: W: no-manual-page-for-binary mesos-ps mesos.x86_64: W: no-manual-page-for-binary mesos-tail mesos.x86_64: W: no-manual-page-for-binary mesos-master mesos.x86_64: W: no-manual-page-for-binary mesos-start-masters.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-masters.sh mesos.x86_64: W: no-manual-page-for-binary mesos-resolve mesos.x86_64: W: no-manual-page-for-binary mesos-execute mesos.x86_64: W: no-manual-page-for-binary mesos-cat mesos.x86_64: W: no-manual-page-for-binary mesos-start-slaves.sh 5 packages and 0 specfiles checked; 1 errors, 26 warnings. # echo 'rpmlint-done:' Requires -------- mesos-libprocess (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libev.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libglog.so.0()(64bit) libhttp_parser.so.2()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) mesos-libprocess-devel (rpmlib, GLIBC filtered): libprocess.so.0()(64bit) mesos-libprocess mesos-stout-devel mesos-stout-devel (rpmlib, GLIBC filtered): boost-devel glog-devel gmock-devel gtest-devel libcurl-devel protobuf-devel zlib-devel mesos-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libmesos-0.16.0.so.0()(64bit) mesos(x86-64) mesos-libprocess-devel mesos (rpmlib, GLIBC filtered): /bin/sh /usr/bin/env config(mesos) libc.so.6()(64bit) libcurl.so.4()(64bit) libev.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libglog.so.0()(64bit) libhttp_parser.so.2()(64bit) libjvm.so()(64bit) libjvm.so(SUNWprivate_1.1)(64bit) libleveldb.so.1()(64bit) libm.so.6()(64bit) libmesos-0.16.0.so.0()(64bit) libprocess.so.0()(64bit) libprotobuf.so.8()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) libzookeeper_mt.so.2()(64bit) mesos-libprocess protobuf-python rtld(GNU_HASH) Provides -------- mesos-libprocess: libprocess.so.0()(64bit) mesos-libprocess mesos-libprocess(x86-64) mesos-libprocess-devel: mesos-libprocess-devel mesos-libprocess-devel(x86-64) mesos-stout-devel: mesos-stout-devel mesos-devel: mesos-devel mesos-devel(x86-64) pkgconfig(mesos) mesos: config(mesos) libmesos-0.16.0.so.0()(64bit) mesos mesos(x86-64) Source checksums ---------------- https://github.com/timothysc/mesos/archive/d3557e8fcd9b96a11fbdd9d28c86bd2b4965c190/mesos-0.16.0-d3557e8.tar.gz : CHECKSUM(SHA256) this package : 975e5d18345258a6d06ff6cfed4514899f77753043d4757588d6ff5c9c2f2518 CHECKSUM(SHA256) upstream package : 975e5d18345258a6d06ff6cfed4514899f77753043d4757588d6ff5c9c2f2518 Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1010512 -m fedora-20-x86_64 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Python, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review