https://bugzilla.redhat.com/show_bug.cgi?id=1022283 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #57 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Nice! All issues noted above are fixed, and even rpmlint is almost happy. Rpmlint ------- Checking: gnulib-docs-0-4.20131219git.fc20.noarch.rpm gnulib-devel-0-4.20131219git.fc20.noarch.rpm git-merge-changelog-0-4.20131219git.fc20.x86_64.rpm gnulib-0-4.20131219git.fc20.src.rpm gnulib-docs.noarch: E: devel-dependency gnulib-devel gnulib-devel.noarch: E: script-without-shebang /usr/share/gnulib/build-aux/gitlog-to-changelog gnulib-devel.noarch: E: script-without-shebang /usr/share/gnulib/build-aux/prefix-gnulib-mk gnulib-devel.noarch: E: script-without-shebang /usr/share/gnulib/build-aux/update-copyright gnulib-devel.noarch: E: script-without-shebang /usr/share/gnulib/build-aux/announce-gen gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/tests/test-posix_spawn2.in.sh 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/ldd.sh.in 0644L /bin/sh gnulib-devel.noarch: E: script-without-shebang /usr/share/gnulib/build-aux/useless-if-before-free gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/lib/config.charset 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/x-to-1.in 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/javaexec.sh.in 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/csharpexec.sh.in 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/csharpcomp.sh.in 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/javacomp.sh.in 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/tests/test-posix_spawn1.in.sh 0644L /bin/sh gnulib-devel.noarch: W: file-not-in-%lang /usr/share/gnulib/tests/locale/fr/LC_MESSAGES/test-quotearg.mo Those are tests and build scripts, so normal rules don't apply. git-merge-changelog.x86_64: W: spelling-error %description -l en_US changelogs -> change logs, change-logs, changelings gnulib.src: W: strange-permission gnulib-0ac90c5.tar.gz 0640L That's a bit strange, but git doesn't store permissions, so when the package is imported this should go away. gnulib.src:5: W: macro-in-comment %name gnulib.src:7: W: macro-in-comment %{moduleX} gnulib.src:8: W: macro-in-comment %{summary_of_moduleX} gnulib.src:9: W: macro-in-comment %{license_of_moduleX} gnulib.src:11: W: macro-in-comment %{moduleX} gnulib.src:12: W: macro-in-comment %description gnulib.src:15: W: macro-in-comment %{moduleX} gnulib.src:15: W: macro-in-comment %{moduleX} gnulib.src:18: W: macro-in-comment %{moduleX} gnulib.src:19: W: macro-in-comment %_prefix gnulib.src:24: W: macro-in-comment %{moduleX} gnulib.src:25: W: macro-in-comment %{buildroot} gnulib.src:27: W: macro-in-comment %{buildroot} gnulib.src:27: W: macro-in-comment %{_bindir} gnulib.src:27: W: macro-in-comment %{moduleX} gnulib.src:27: W: macro-in-comment %{buildroot} gnulib.src:27: W: macro-in-comment %{_mandir} gnulib.src:27: W: macro-in-comment %{moduleX} gnulib.src:29: W: macro-in-comment %{moduleX} gnulib.src:30: W: macro-in-comment %{_bindir} gnulib.src:30: W: macro-in-comment %{moduleX} gnulib.src:31: W: macro-in-comment %{_mandir} gnulib.src:31: W: macro-in-comment %{moduleX} OK. gnulib.src:149: W: unversioned-explicit-provides gnulib Ooops, I think I suggested this, and it should be Provides: gnulib = %{version}-%{release} 4 packages and 0 specfiles checked; 15 errors, 27 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint gnulib-devel gnulib-docs git-merge-changelog gnulib-devel.noarch: E: script-without-shebang /usr/share/gnulib/build-aux/gitlog-to-changelog gnulib-devel.noarch: E: script-without-shebang /usr/share/gnulib/build-aux/prefix-gnulib-mk gnulib-devel.noarch: E: script-without-shebang /usr/share/gnulib/build-aux/update-copyright gnulib-devel.noarch: E: script-without-shebang /usr/share/gnulib/build-aux/announce-gen gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/tests/test-posix_spawn2.in.sh 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/ldd.sh.in 0644L /bin/sh gnulib-devel.noarch: E: script-without-shebang /usr/share/gnulib/build-aux/useless-if-before-free gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/lib/config.charset 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/x-to-1.in 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/javaexec.sh.in 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/csharpexec.sh.in 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/csharpcomp.sh.in 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/build-aux/javacomp.sh.in 0644L /bin/sh gnulib-devel.noarch: E: non-executable-script /usr/share/gnulib/tests/test-posix_spawn1.in.sh 0644L /bin/sh gnulib-devel.noarch: W: file-not-in-%lang /usr/share/gnulib/tests/locale/fr/LC_MESSAGES/test-quotearg.mo gnulib-docs.noarch: E: devel-dependency gnulib-devel git-merge-changelog.x86_64: W: spelling-error %description -l en_US changelogs -> change logs, change-logs, changelings 3 packages and 0 specfiles checked; 15 errors, 2 warnings. # echo 'rpmlint-done:' All OK. Requires -------- gnulib-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/perl bison coreutils diffutils gettext-devel gperf libtool make patch perl(Digest::MD5) perl(File::Basename) perl(File::Find) perl(Getopt::Long) perl(IO::File) perl(POSIX) perl(constant) perl(strict) perl(warnings) texinfo gnulib-docs (rpmlib, GLIBC filtered): /bin/sh gnulib-devel info git-merge-changelog (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) Provides -------- gnulib-devel: gnulib gnulib-devel gnulib-docs: gnulib-docs git-merge-changelog: git-merge-changelog git-merge-changelog(x86-64) AutoTools: Obsoleted m4s found ------------------------------ AM_PROG_LIBTOOL found in: gnulib- 0ac90c5/tests/havelib/rpathy/configure.ac:23, gnulib- 0ac90c5/tests/havelib/rpathz/configure.ac:23, gnulib- 0ac90c5/tests/havelib/rpathx/configure.ac:23 Package is APPROVED. There's one issue with Provides noted above, but there's no need to upload another version, it can be fixed in the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review