https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Zoltan Boszormenyi <zboszor@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zboszor@xxxxx --- Comment #9 from Zoltan Boszormenyi <zboszor@xxxxx> --- Informal review: 1. rpmlint gives this: $ rpmlint -i -v plv8.spec plv8.spec:29: W: mixed-use-of-spaces-and-tabs (spaces: line 29, tab: line 4) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. plv8.spec: I: checking-url http://plv8js.googlecode.com/files/plv8-1.4.1.zip (timeout 10 seconds) plv8.spec: W: invalid-url Source0: http://plv8js.googlecode.com/files/plv8-1.4.1.zip HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. 0 packages and 1 specfiles checked; 0 errors, 2 warnings. I followed the links on Googe Code and the Source0 URL should be https://plv8js.googlecode.com/files/plv8-1.4.1.zip , instead of http://... Tabs and spaces should be consistently used. 2. PostgreSQL extra PL packages are called postgresql-plsomething, calling it "plv8" doesn't say much. 3. Scratch builds were completed for f19, f20, f21, rawhide, failed for dist-5E-epel and dist-6E-epel. http://koji.fedoraproject.org/koji/taskinfo?taskID=6308990 http://koji.fedoraproject.org/koji/taskinfo?taskID=6308983 http://koji.fedoraproject.org/koji/taskinfo?taskID=6309024 http://koji.fedoraproject.org/koji/taskinfo?taskID=6309028 http://koji.fedoraproject.org/koji/taskinfo?taskID=6309011 http://koji.fedoraproject.org/koji/taskinfo?taskID=6309018 4. Remove BuildRoot tag. 5. Group tags are not needed anymore, remove them from the spec file. 6. "%defattr(-,root,root)" is also not needed, remove it. 7. Remove %clean section. 8. Remove "rm -rf %{buildroot}" in %install 9. I tried "make install DESTDIR=..." manually and there is no *.sql file in %{datadir}, i.e. in $DESTDIR/usr/share. So the extra "rm -f %{buildroot}%{_datadir}/*.sql" line is not needed in the %install section after "make install". Remove it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review