https://bugzilla.redhat.com/show_bug.cgi?id=970393 Zoltan Boszormenyi <zboszor@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zboszor@xxxxx --- Comment #7 from Zoltan Boszormenyi <zboszor@xxxxx> --- Informal review: 1. The package is already present in the rpmfusion-free repository. A couple of years ago I asked why this is not present in Fedora and the answer was that it's because the JBig compression is patented. I used a HP LaserJet 1020 at the time which wasn't supported, only by this software. Shortly after that hplip started supporting a lot of their "winprinters" and setting up HP printers became simply "hp-setup". But hplip doesn't drive Konica-Minolta (and other) printers using the same ZjStream protocol, so the package is useful. It seems the jbigkit library (which is also used by foo2zjs) is already included in Fedora. When I try to remove it, the dependencies lead to libtiff, then gdk-pixbuf2, then half of the installed universe, so the patent problem must have been eliminated. (IANAL) About the RPM spec file and the patches included in the SRPM: 2. Have you tried sending the patches to the upstream maintainer? 3. Group tags are not needed, remove them. 4. These Requires lines are also not needed, RPM figures it out automatically: Requires: %{name} = %{version}-%{release} 5. rpmlint only spits one warning: $ rpmlint -i -v foo2zjs.spec foo2zjs.spec: W: invalid-url Source0: foo2zjs-20130813.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. 0 packages and 1 specfiles checked; 0 errors, 1 warnings. The website only lists the current latest foo2zjs.tar.gz and doesn't provide any revision history. No one can known whether the tar file in the SRPM actually matches any released version of foo2zjs. 6. The correct working of this driver needs extra binary data, like firmware files for the LaserJet 1005, 1020, etc. printers or ICM data files for others. They are fetched via the "./getweb" script but it's neither run (to include the downloaded extra data files) nor included in the binary RPM. In the second case, the user should also be told to run the script and add UDEV rules to download the firmware into the printer whenever it's turned on. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review