https://bugzilla.redhat.com/show_bug.cgi?id=1034523 --- Comment #12 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- TL;DR: Looks good; scratch build successful. Approved - from a package review perspective. However: I'm not a sponsor, you need to wait someone to sponsor you for Fedora package collection. Long: 1. Manual Review ~~~~~~~~~~~~~~~~ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. - GPLv3+ [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. === $ fedora-review --rpm-spec -n sqlcli-2-3.fc19.src.rpm $ cd sqlcli $ tree | grep COPYING │ ├── COPYING [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/kashyap/rpmbuild/SRPMS/sqlcli/licensecheck.txt - [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines Python: [x]: Python eggs must not download any dependencies during the build process. $ cat ./rpms-unpacked/sqlcli-2-3.fc18.noarch.rpm/usr/lib/python2.7/site-packages/sqlcli-1-py2.7.egg-info/dependency_links.txt [x]: A package which is used by another package via an egg interface should provide egg info. ==== $ tree ./rpms-unpacked/sqlcli-2-3.fc18.noarch.rpm/usr/lib/python2.7/site-packages/sqlcli-1-py2.7.egg-info ./rpms-unpacked/sqlcli-2-3.fc18.noarch.rpm/usr/lib/python2.7/site-packages/sqlcli-1-py2.7.egg-info ├── dependency_links.txt ├── entry_points.txt ├── PKG-INFO ├── requires.txt ├── SOURCES.txt └── top_level.txt ==== [x]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. 2. Scratch build ~~~~~~~~~~~~~~~~ With latest SRPM, successful: kashyap@SRPMS$ koji build --scratch f21 sqlcli-2-3.fc19.src.rpm Uploading srpm: sqlcli-2-3.fc19.src.rpm [====================================] 100% 00:00:01 17.65 KiB 16.16 KiB/sec Created task: 6301871 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6301871 Watching tasks (this may be safely interrupted)... 6301871 build (f21, sqlcli-2-3.fc19.src.rpm): free 6301871 build (f21, sqlcli-2-3.fc19.src.rpm): free -> open (buildvm-21.phx2.fedoraproject.org) 6301872 buildArch (sqlcli-2-3.fc19.src.rpm, noarch): open (buildvm-01.phx2.fedoraproject.org) 6301872 buildArch (sqlcli-2-3.fc19.src.rpm, noarch): open (buildvm-01.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 6301871 build (f21, sqlcli-2-3.fc19.src.rpm): open (buildvm-21.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 6301871 build (f21, sqlcli-2-3.fc19.src.rpm) completed successfully kashyap@SRPMS$ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review