https://bugzilla.redhat.com/show_bug.cgi?id=1043283 Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- APPROVED ! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "*No copyright* GPL (v3 or later)", "BSD (2 clause)", "LGPL (v2.1 or later)", "GPL (v3)", "Public domain GPL (v3 or later)", "GPL (v2.1 or later) (with incorrect FSF address) LGPL (v2.1 or later) (with incorrect FSF address)". 1929 files have unknown license. Detailed output of licensecheck in /home/rave/Test/review- shogun/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/lua/5.2 [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/lua/5.2, /usr/lib64/ruby/vendor_ruby, /usr/lib64/ruby [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in shogun-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: shogun-3.1.0-0.1.git20131212.70e774d.fc21.x86_64.rpm shogun-cli-3.1.0-0.1.git20131212.70e774d.fc21.x86_64.rpm shogun-devel-3.1.0-0.1.git20131212.70e774d.fc21.x86_64.rpm shogun-doc-3.1.0-0.1.git20131212.70e774d.fc21.noarch.rpm lua-shogun-3.1.0-0.1.git20131212.70e774d.fc21.x86_64.rpm octave-shogun-3.1.0-0.1.git20131212.70e774d.fc21.x86_64.rpm python-shogun-3.1.0-0.1.git20131212.70e774d.fc21.x86_64.rpm ruby-shogun-3.1.0-0.1.git20131212.70e774d.fc21.x86_64.rpm shogun-3.1.0-0.1.git20131212.70e774d.fc20.src.rpm shogun.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s shogun.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee shogun.x86_64: W: shared-lib-calls-exit /usr/lib64/libshogun.so.15.0 exit@GLIBC_2.2.5 shogun-cli.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s shogun-cli.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee shogun-cli.x86_64: W: no-documentation shogun-cli.x86_64: W: no-manual-page-for-binary shogun shogun-devel.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s shogun-devel.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee shogun-doc.noarch: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s shogun-doc.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee lua-shogun.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s lua-shogun.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee lua-shogun.x86_64: W: no-documentation octave-shogun.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s octave-shogun.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee octave-shogun.x86_64: W: no-documentation python-shogun.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s python-shogun.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee python-shogun.x86_64: W: no-documentation ruby-shogun.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s ruby-shogun.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee ruby-shogun.x86_64: W: no-documentation shogun.src: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s shogun.src: W: spelling-error %description -l en_US pre -> per, ore, pee shogun.src:192: W: unversioned-explicit-provides bundled(dSFMT) shogun.src:193: W: unversioned-explicit-provides bundled(gnulib) shogun.src:194: W: unversioned-explicit-provides bundled(liblinear) shogun.src:195: W: unversioned-explicit-provides bundled(libsvm) shogun.src:196: W: unversioned-explicit-provides bundled(SFMT) shogun.src:197: W: unversioned-explicit-provides bundled(SVMlin) # this is for mono, we can ignorew this shogun.src:842: E: hardcoded-library-path in %{_prefix}/lib/cli/%{name} shogun.src: E: specfile-error sh: octave-config: command not found shogun.src: E: specfile-error sh: octave-config: command not found shogun.src: E: specfile-error which: no mono in (/usr/lib64/qt-3.3/bin:/usr/libexec/lightdm:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/home/rave/.local/bin:/home/rave/bin) 9 packages and 0 specfiles checked; 4 errors, 31 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ruby-shogun shogun-doc lua-shogun shogun-cli python-sho gun shogun shogun-devel octave-shogun ruby-shogun.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s ruby-shogun.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee ruby-shogun.x86_64: W: no-documentation shogun-doc.noarch: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s shogun-doc.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee lua-shogun.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s lua-shogun.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee lua-shogun.x86_64: W: no-documentation shogun-cli.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s shogun-cli.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee shogun-cli.x86_64: W: no-documentation shogun-cli.x86_64: W: no-manual-page-for-binary shogun python-shogun.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s python-shogun.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee python-shogun.x86_64: W: no-documentation shogun.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s shogun.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee shogun.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libshogun.so.15.0 /lib64/liblpsolve55.so shogun.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libshogun.so.15.0 /lib64/libdl.so.2 shogun.x86_64: W: shared-lib-calls-exit /usr/lib64/libshogun.so.15.0 exit@GLIBC_2.2.5 shogun-devel.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s shogun-devel.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee octave-shogun.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s octave-shogun.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee octave-shogun.x86_64: W: no-documentation 8 packages and 0 specfiles checked; 0 errors, 25 warnings. # echo 'rpmlint-done:' Requires -------- ruby-shogun (rpmlib, GLIBC filtered): libColPack.so.0()(64bit) libarpack.so.2()(64bit) libarprec.so.0()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libglpk.so.36()(64bit) libhdf5.so.8()(64bit) libjson-c.so.2()(64bit) liblpsolve55.so()(64bit) liblzma.so.5()(64bit) liblzo2.so.2()(64bit) libm.so.6()(64bit) libnlopt_cxx.so.0()(64bit) libprotobuf.so.8()(64bit) libpthread.so.0()(64bit) libruby.so.2.0()(64bit) libshogun.so.15()(64bit) libsnappy.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libtatlas.so.3()(64bit) libxml2.so.2()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) ruby(release) rubygem(narray)(x86-64) shogun(x86-64) shogun-doc (rpmlib, GLIBC filtered): lua-shogun (rpmlib, GLIBC filtered): libColPack.so.0()(64bit) libarpack.so.2()(64bit) libarprec.so.0()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libglpk.so.36()(64bit) libhdf5.so.8()(64bit) libjson-c.so.2()(64bit) liblpsolve55.so()(64bit) liblua-5.2.so()(64bit) liblzma.so.5()(64bit) liblzo2.so.2()(64bit) libm.so.6()(64bit) libnlopt_cxx.so.0()(64bit) libprotobuf.so.8()(64bit) libpthread.so.0()(64bit) libshogun.so.15()(64bit) libsnappy.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libtatlas.so.3()(64bit) libxml2.so.2()(64bit) libz.so.1()(64bit) lua(abi) lua(x86-64) rtld(GNU_HASH) shogun(x86-64) shogun-cli (rpmlib, GLIBC filtered): libColPack.so.0()(64bit) libarpack.so.2()(64bit) libarprec.so.0()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglpk.so.36()(64bit) libgomp.so.1()(64bit) libhdf5.so.8()(64bit) libjson-c.so.2()(64bit) liblpsolve55.so()(64bit) liblzma.so.5()(64bit) liblzo2.so.2()(64bit) libm.so.6()(64bit) libnlopt_cxx.so.0()(64bit) libprotobuf.so.8()(64bit) libpthread.so.0()(64bit) libshogun.so.15()(64bit) libsnappy.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libtatlas.so.3()(64bit) libxml2.so.2()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) shogun(x86-64) python-shogun (rpmlib, GLIBC filtered): libColPack.so.0()(64bit) libarpack.so.2()(64bit) libarprec.so.0()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libglpk.so.36()(64bit) libhdf5.so.8()(64bit) libjson-c.so.2()(64bit) liblpsolve55.so()(64bit) liblzma.so.5()(64bit) liblzo2.so.2()(64bit) libm.so.6()(64bit) libnlopt_cxx.so.0()(64bit) libprotobuf.so.8()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) libshogun.so.15()(64bit) libsnappy.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libtatlas.so.3()(64bit) libxml2.so.2()(64bit) libz.so.1()(64bit) numpy(x86-64) python(abi) python(x86-64) rtld(GNU_HASH) scipy(x86-64) shogun(x86-64) shogun (rpmlib, GLIBC filtered): /sbin/ldconfig libColPack.so.0()(64bit) libarpack.so.2()(64bit) libarprec.so.0()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libglpk.so.36()(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_1.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libgomp.so.1(OMP_2.0)(64bit) libhdf5.so.8()(64bit) libjson-c.so.2()(64bit) liblpsolve55.so()(64bit) liblzma.so.5()(64bit) liblzma.so.5(XZ_5.0)(64bit) liblzo2.so.2()(64bit) libm.so.6()(64bit) libnlopt_cxx.so.0()(64bit) libprotobuf.so.8()(64bit) libpthread.so.0()(64bit) libsnappy.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtatlas.so.3()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.7.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) shogun-devel (rpmlib, GLIBC filtered): ColPack-devel(x86-64) NLopt-devel(x86-64) arpack-devel(x86-64) arprec-devel(x86-64) atlas-devel(x86-64) blas-devel(x86-64) bzip2-devel(x86-64) eigen3-devel glpk-devel(x86-64) hdf5-devel(x86-64) json-c-devel(x86-64) libcurl-devel(x86-64) libshogun.so.15()(64bit) libxml2-devel(x86-64) lpsolve-devel(x86-64) lzo-devel(x86-64) qd-devel(x86-64) shogun(x86-64) snappy-devel(x86-64) tapkee-devel xz-devel(x86-64) zlib-devel(x86-64) octave-shogun (rpmlib, GLIBC filtered): libColPack.so.0()(64bit) libarpack.so.2()(64bit) libarprec.so.0()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libglpk.so.36()(64bit) libhdf5.so.8()(64bit) libjson-c.so.2()(64bit) liblpsolve55.so()(64bit) liblzma.so.5()(64bit) liblzo2.so.2()(64bit) libm.so.6()(64bit) libnlopt_cxx.so.0()(64bit) liboctinterp.so.1()(64bit) libprotobuf.so.8()(64bit) libpthread.so.0()(64bit) libshogun.so.15()(64bit) libsnappy.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libtatlas.so.3()(64bit) libxml2.so.2()(64bit) libz.so.1()(64bit) octave(api) octave(x86-64) rtld(GNU_HASH) shogun(x86-64) Provides -------- ruby-shogun: ruby-shogun ruby-shogun(x86-64) shogun-doc: shogun-doc lua-shogun: lua-shogun lua-shogun(x86-64) shogun-cli: shogun-cli shogun-cli(x86-64) python-shogun: python-shogun python-shogun(x86-64) shogun: bundled(SFMT) bundled(SVMlin) bundled(dSFMT) bundled(gnulib) bundled(liblinear) bundled(libsvm) libshogun.so.15()(64bit) shogun shogun(x86-64) shogun-devel: shogun-devel shogun-devel(x86-64) octave-shogun: octave-shogun octave-shogun(x86-64) Unversioned so-files -------------------- lua-shogun: /usr/lib64/lua/5.2/libmodshogun.so python-shogun: /usr/lib64/python2.7/site-packages/_modshogun.so ruby-shogun: /usr/lib64/ruby/vendor_ruby/modshogun.so Source checksums ---------------- https://github.com/shogun-toolbox/shogun/archive/70e774d7432051e56b0b79554376194c3bf21b12.tar.gz#/shogun-3.1.0-git20131212-70e774d.tar.gz : CHECKSUM(SHA256) this package : 30a5c67bc57c2ccb7ed36eb48d3447381f6630383084af59b39f4b8cfcbe4115 CHECKSUM(SHA256) upstream package : 30a5c67bc57c2ccb7ed36eb48d3447381f6630383084af59b39f4b8cfcbe4115 https://github.com/shogun-toolbox/shogun-data/archive/39f2ac8143ed6b2018ce5b420b9deb6935b7eb78.tar.gz#/shogun-data-3.1.0-git20131210-39f2ac8.tar.gz : CHECKSUM(SHA256) this package : 67359e99c86bc6730c59c381ebe638499638fb4f1fd6aadc6c2718603703a83c CHECKSUM(SHA256) upstream package : 67359e99c86bc6730c59c381ebe638499638fb4f1fd6aadc6c2718603703a83c http://googlemock.googlecode.com/files/gmock-1.7.0.zip : CHECKSUM(SHA256) this package : 26fcbb5925b74ad5fc8c26b0495dfc96353f4d553492eb97e85a8a6d2f43095b CHECKSUM(SHA256) upstream package : 26fcbb5925b74ad5fc8c26b0495dfc96353f4d553492eb97e85a8a6d2f43095b Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -v -p -n shogun -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review