https://bugzilla.redhat.com/show_bug.cgi?id=1040459 --- Comment #7 from Dan Fruehauf <malkodan@xxxxxxxxx> --- (In reply to Michael Scherer from comment #6) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > - I am not sure that nm-iodine-auth-dialog belong to the main > package, since this pull several gnome libraries. Can you check if it work > fine without it ? That's an issue we have with NetworkManager VPN packages across the board. The guys upstream are working on a fix to properly separate the auth dialog to a not require GUI. At the moment it requires it though. One might ask why split into 2 packages then? I submitted patches to all the NetworkManager VPN plugins spec files to separate into 2 packages (core and gnome) as this is the direction we're going to. By all means, the auth dialog should not require gnome, however at the moment it still does :/ I'll see if I can dig up the bug where we had the discussion about it. > > > ===== MUST items ===== > > C/C++: > [x]: Package does not contain kernel modules. > [x]: Package contains no static executables. > [x]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. > [x]: Package does not contain any libtool archives (.la) > [x]: Rpath absent or only used for internal libs. > > Generic: > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "LGPL (v2 or later)", "GPL (v2 or later)". Detailed output of > licensecheck in /tmp/1040459-NetworkManager-iodine/licensecheck.txt > [x]: License file installed when any subpackage combination is installed. > [x]: Package must own all directories that it creates. > Note: Directories without known owners: /etc/NetworkManager, > /etc/NetworkManager/VPN, /usr/lib64/NetworkManager > [x]: %build honors applicable compiler flags or justifies otherwise. > [x]: Package contains no bundled libraries without FPC exception. > [x]: Changelog in prescribed format. > [x]: Sources contain only permissible code or content. > [-]: Package contains desktop file if it is a GUI application. > [-]: Development files must be in a -devel package > [x]: Package uses nothing in %doc for runtime. > [x]: The spec file handles locales properly. > [x]: Package consistently uses macros (instead of hard-coded directory > names). > [x]: Package is named according to the Package Naming Guidelines. > [x]: Package does not generate any conflict. > [x]: Package obeys FHS, except libexecdir and /usr/target. > [-]: If the package is a rename of another package, proper Obsoletes and > Provides are present. > [x]: Requires correct, justified where necessary. > [x]: Spec file is legible and written in American English. > [-]: Package contains systemd file(s) if in need. > [x]: Useful -debuginfo package or justification otherwise. > [x]: Package is not known to require an ExcludeArch tag. > [x]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 61440 bytes in 4 files. > [x]: Package complies to the Packaging Guidelines > [x]: Package successfully compiles and builds into binary rpms on at least > one > supported primary architecture. > [x]: Package installs properly. > [x]: Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). > [x]: If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. > [x]: Package requires other packages for directories it uses. > [x]: Package does not own files or directories owned by other packages. > [x]: All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT > [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > [x]: Each %files section contains %defattr if rpm < 4.4 > [x]: Macros in Summary, %description expandable at SRPM build time. > [x]: Package does not contain duplicates in %files. > [x]: Permissions on files are set properly. > [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't > work. > [x]: Package is named using only allowed ASCII characters. > [x]: Package do not use a name that already exist > [x]: Package is not relocatable. > [x]: Sources used to build the package match the upstream source, as provided > in the spec URL. > [x]: Spec file name must match the spec package %{name}, in the format > %{name}.spec. > [x]: File names are valid UTF-8. > [x]: Packages must not store files under /srv, /opt or /usr/local > > ===== SHOULD items ===== > > Generic: > [x]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. > [!]: Final provides and requires are sane (see attachments). > [x]: Package functions as described. > [x]: Latest version is packaged. > [x]: Package does not include license text files separate from upstream. > [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. > [-]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. > [x]: Package should compile and build into binary rpms on all supported > architectures. > [-]: %check is present and all tests pass. > [x]: Packages should try to preserve timestamps of original installed files. > [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file > [x]: Sources can be downloaded from URI in Source: tag > [x]: Reviewer should test that the package builds in mock. > [x]: Buildroot is not present > [x]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > [x]: Dist tag is present (not strictly required in GL). > [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. > [x]: Fully versioned dependency in subpackages if applicable. > [x]: Uses parallel make %{?_smp_mflags} macro. > [x]: SourceX tarball generation or download is documented. > [x]: SourceX is a working URL. > [x]: Spec use %global instead of %define unless justified. > > ===== EXTRA items ===== > > Generic: > [x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). > [x]: Large data in /usr/share should live in a noarch subpackage if package > is > arched. > [x]: Package should not use obsolete m4 macros > [x]: Spec file according to URL is the same as in SRPM. > > > Rpmlint > ------- > Checking: NetworkManager-iodine-0.0.4-2.fc20.x86_64.rpm > NetworkManager-iodine-gnome-0.0.4-2.fc20.x86_64.rpm > NetworkManager-iodine-0.0.4-2.fc20.src.rpm > NetworkManager-iodine.x86_64: W: non-conffile-in-etc > /etc/dbus-1/system.d/nm-iodine-service.conf > NetworkManager-iodine.x86_64: W: non-conffile-in-etc > /etc/NetworkManager/VPN/nm-iodine-service.name > 3 packages and 0 specfiles checked; 0 errors, 2 warnings. > > > > > Rpmlint (installed packages) > ---------------------------- > # rpmlint NetworkManager-iodine-gnome NetworkManager-iodine > NetworkManager-iodine.x86_64: W: non-conffile-in-etc > /etc/dbus-1/system.d/nm-iodine-service.conf > NetworkManager-iodine.x86_64: W: non-conffile-in-etc > /etc/NetworkManager/VPN/nm-iodine-service.name > 2 packages and 0 specfiles checked; 0 errors, 2 warnings. > # echo 'rpmlint-done:' > > > > Requires > -------- > NetworkManager-iodine-gnome (rpmlib, GLIBC filtered): > NetworkManager-iodine(x86-64) > libatk-1.0.so.0()(64bit) > libc.so.6()(64bit) > libcairo-gobject.so.2()(64bit) > libcairo.so.2()(64bit) > libdbus-1.so.3()(64bit) > libdbus-glib-1.so.2()(64bit) > libgdk-3.so.0()(64bit) > libgdk_pixbuf-2.0.so.0()(64bit) > libgio-2.0.so.0()(64bit) > libglib-2.0.so.0()(64bit) > libgobject-2.0.so.0()(64bit) > libgtk-3.so.0()(64bit) > libnm-glib-vpn.so.1()(64bit) > libnm-glib.so.4()(64bit) > libnm-util.so.2()(64bit) > libpango-1.0.so.0()(64bit) > libpangocairo-1.0.so.0()(64bit) > libpthread.so.0()(64bit) > nm-connection-editor > rtld(GNU_HASH) > > NetworkManager-iodine (rpmlib, GLIBC filtered): > iodine-client > libatk-1.0.so.0()(64bit) > libc.so.6()(64bit) > libcairo-gobject.so.2()(64bit) > libcairo.so.2()(64bit) > libdbus-1.so.3()(64bit) > libdbus-glib-1.so.2()(64bit) > libgdk-3.so.0()(64bit) > libgdk_pixbuf-2.0.so.0()(64bit) > libgio-2.0.so.0()(64bit) > libglib-2.0.so.0()(64bit) > libgnome-keyring.so.0()(64bit) > libgobject-2.0.so.0()(64bit) > libgthread-2.0.so.0()(64bit) > libgtk-3.so.0()(64bit) > libnm-glib-vpn.so.1()(64bit) > libnm-glib.so.4()(64bit) > libnm-util.so.2()(64bit) > libpango-1.0.so.0()(64bit) > libpangocairo-1.0.so.0()(64bit) > libpthread.so.0()(64bit) > rtld(GNU_HASH) > shared-mime-info > > > > Provides > -------- > NetworkManager-iodine-gnome: > NetworkManager-iodine-gnome > NetworkManager-iodine-gnome(x86-64) > > NetworkManager-iodine: > NetworkManager-iodine > NetworkManager-iodine(x86-64) > > > > Unversioned so-files > -------------------- > NetworkManager-iodine-gnome: > /usr/lib64/NetworkManager/libnm-iodine-properties.so > > Source checksums > ---------------- > http://honk.sigxcpu.org/projects/network-manager-iodine/tarballs/ > NetworkManager-iodine-0.0.4.tar.xz : > CHECKSUM(SHA256) this package : > 37e6707be81413d47b7902a892922497e150e9bf7b72e6880a39767dd20eecf3 > CHECKSUM(SHA256) upstream package : > 37e6707be81413d47b7902a892922497e150e9bf7b72e6880a39767dd20eecf3 > > > Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 > Command line :/usr/bin/fedora-review -b 1040459 > Buildroot used: fedora-20-x86_64 > Active plugins: Generic, Shell-api, C/C++ > Disabled plugins: Java, Python, SugarActivity, Perl, R, PHP, Ruby > Disabled flags: EPEL5, EXARCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review