https://bugzilla.redhat.com/show_bug.cgi?id=1034341 --- Comment #20 from Simon Farnsworth <simon@xxxxxxxxxxxx> --- (In reply to Michael Schwendt from comment #19) > Hmm, I haven't had a look at the spec file before... > > > Name: gstreamer1-python > > Since it's a Python module to make it easier to use GStreamer within Python, > it should following the %parent-%child naming guidelines for Python add-on > packages, shouldn't it? > > Name: python-gstreamer1 > > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_. > 28General.29 > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_. > 28python_modules.29 > I was following the example of gstreamer-python, its gstreamer 0.10 equivalent. I'll rename it to avoid having to rename later. > > > Requires: gstreamer1 >= 1.2.0 > > It already depends on the libstreamer SONAME automatically, and a comment > should explain why this explicit dependency with minimum version is needed: > https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires > > Since the dep should be arch-specific, add %{?_isa} to it: gstreamer1%{?_isa} > I'll add the comment and %{?_isa} - it doesn't build with less than 1.2.0, and I don't test it against older GStreamer, even though it claims the libgstreamer 1.0 SONAME. > [...] > > Using wildcards in %files lists can be convenient, but may be more fragile. > In this case, > > %{python2_sitearch}/gi/overrides/* > > includes "anything" and could silently (and without causing a build failure) > drop parts of the API and break dependencies, whereas > > %{python2_sitearch}/gi/overrides/GstPbutils.py* > %{python2_sitearch}/gi/overrides/Gst.py* > %{python2_sitearch}/gi/overrides/_gi_gst.so > > would be a safer compromise. It would ensure that those files must be > available. I'll make that change instead of the wide open wildcard. New package at: Spec URL: http://90.155.96.198/sfarnsworth/python-gstreamer1.spec SRPM URL: http://90.155.96.198/sfarnsworth/python-gstreamer1-1.1.90-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review