[Bug 1036297] Review Request: python-libturpial - library needed to new turpial (twitter client) version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1036297



--- Comment #14 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Created attachment 836146
  --> https://bugzilla.redhat.com/attachment.cgi?id=836146&action=edit
Use pkgdocdir and sed for build the package

there aren't any special reason on our guidelines for avoid the conditionals in
the specs,therefore I do not have any objection on the form that is wrote the
spec.

BUT, I have some advices for the spec.

this global macro
 %{!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}-%{version}}
can be helpful, note that,  if {%_pkdocdir} is present, macro can change the
value to /usr/share/doc/$name or /usr/share/doc/$name-$version, according the
fedora version

now, you can use 

sed -i 's|./|'"%{_pkgdocdir}"'|' setup.py

A better way for manage literal strings with forward slashes (no characters
escape),is to using a delimiter in the sed command that doesn't interfere with
the directory delimiter "/".

Now, you can use in %doc section
%doc ChangeLog AUTHORS COPYING
without worrying about the location of files

in the attachment you can see an example

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]