Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: scim https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226395 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-03-26 23:33 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM. + rpmlint is NOT silent for RPMs scim, scim-devel, scim-libs The Warning is of obsolete-not-provided which can be ignored. + source files match upstream. e2c71f9f54eda65cc1a515863a1839d2 /root/scim/devel/scim-1.4.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text COPYING is included in package. + %doc is NOT small so scim-doc subpackage required. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + scim.pc, scim-gtkutils.pc and scim-x11utils.pc files are present. + scim-devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + GUI app. + scim RPM Provides: aaa-frontend-setup.so aaa-imengine-setup.so config(scim) = 1.4.5-11.fc7 panel-gtk-setup.so rawcode.so rawcode.so(SCIM_IMENGINE_1.0) sctc.so setup.so socket.so x11.so + scim-libs Provides: libscim-1.0.so.8 libscim-1.0.so.8(LIBSCIM_1.0) libscim-gtkutils-1.0.so.8 libscim-x11utils-1.0.so.8 simple.so simple.so(SCIM_CONFIG_1.0) socket.so socket.so(SCIM_CONFIG_1.0) socket.so(SCIM_IMENGINE_1.0) + scim-gtk Provides: im-scim.so im-scim.so(IM_SCIM_1.0) APPROVED. Thanks to mtasaka for his review comments. And Thanks for Jens. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review