https://bugzilla.redhat.com/show_bug.cgi?id=1028165 --- Comment #3 from Adrien Devresse <adev88@xxxxxxxxx> --- Review and good one : Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Contains file under BSD license but only ASL 2.0 is signaled - no ownership defined on /etc/globus - Macro could be used in "/usr/bin/srun", "/usr/bin/sbatch", etc. Comments: ========= - No Unit tests or %check section - some direct dependencies that could be avoided, but I let this up to you as in ( https://bugzilla.redhat.com/show_bug.cgi?id=1028164 ) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. -> See LICENSE.BSD, need signal BSD and ASL 2.0 license [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/globus [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/globus [x]: Package does not own files or directories owned by other packages. -> multiple ownership from independant perl scripts, not a problem. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required -> EPEL 5 requirement [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed -> EPEL 5 requirement [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [x]: Buildroot is not present Note: Buildroot: present but not needed -> Requirement EPEL 5 [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) -> Requirement EPEL 5 [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. -> conf package [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. -> No Arch [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: globus-gram-job-manager-slurm-1.2-1.el6.noarch.rpm globus-gram-job-manager-slurm-1.2-1.el6.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint globus-gram-job-manager-slurm globus-gram-job-manager-slurm.noarch: I: enchant-dictionary-not-found en_US 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- globus-gram-job-manager-slurm (rpmlib, GLIBC filtered): /bin/sh config(globus-gram-job-manager-slurm) globus-common-progs globus-gass-cache-program globus-gatekeeper globus-gram-job-manager globus-gram-job-manager-scripts perl perl(:MODULE_COMPAT_5.10.1) perl(Config) perl(Globus::Core::Config) perl(Globus::Core::Paths) perl(Globus::GRAM::Error) perl(Globus::GRAM::JobManager) perl(Globus::GRAM::JobState) perl(IO::File) perl(IPC::Open3) perl(strict) Provides -------- globus-gram-job-manager-slurm: config(globus-gram-job-manager-slurm) globus-gram-job-manager-slurm perl(Globus::GRAM::JobManager::slurm) Source checksums ---------------- http://www.globus.org/ftppub/gt5/5.2/5.2.5/packages/src/globus_gram_job_manager_slurm-1.2.tar.gz : CHECKSUM(SHA256) this package : 0dec0b95fe26b2ba0b646ffe814f368335c7226ce1ab6b41d2f6cf36ac048eed CHECKSUM(SHA256) upstream package : 0dec0b95fe26b2ba0b646ffe814f368335c7226ce1ab6b41d2f6cf36ac048eed BUILDS: ======= Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6284156 -> Success F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6284165 -> Success EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=6284329 -> Success EL5: http://koji.fedoraproject.org/koji/taskinfo?taskID=6284469 ->Success Adrien -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review