[Bug 1040027] Review Request: double-conversion - Library providing binary-decimal and decimal-binary routines for IEEE doubles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1040027



--- Comment #3 from Milan Bouchet-Valat <nalimilan@xxxxxxx> ---
Thanks for the fast review! I've updated the links above with an improved
version. See below for replies.

(In reply to Orion Poplawski from comment #1)
> - rpmbuild -ba --without static_libs double-conversion.spec fails with:
> 
> RPM build errors:
>     Installed (but unpackaged) file(s) found:
>    /usr/lib64/libdouble-conversion.a
>    /usr/lib64/libdouble-conversion_pic.a
Ah, I hadn't tried this, for some reason I assumed Koji would have done that.
I've added an option to SConstruct to avoid installing static libraries. I can
drop this feature if you think it's better, but now that it exists, I guess it
could be useful to somebody.

> - I don't understand the use of %ghost:
> 
> %{_libdir}/libdouble-conversion.so.*.*.*
> %ghost %{_libdir}/libdouble-conversion.so.2
> 
> Normally this is just:
> 
> %{_libdir}/libdouble-conversion.so.*
> 
> although I recommend:
> 
> %{_libdir}/libdouble-conversion.so.2*
> 
> to detect soname bumps.
Actually I couldn't understand why PLD used that, but since I'm new to .spec
files I assumed it was correct. Maybe it's supposed to work when
libdouble-conversion.so.2 is automatically created by ldconfig from
libdouble-conversion.so.2.0.0. Your solution makes more sense to me, since we
actually ship the file.

> - Drop BuildRoot (unless targeting EPEL 5).
Same - copied from PLD.

> - macro consistency - drop the %{__rm} in clean, just use rm as elsewhere.
Same.

> - Use %{?dist} in Release.
Done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]