https://bugzilla.redhat.com/show_bug.cgi?id=1040453 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Vít Ondruch <vondruch@xxxxxxxxxx> --- And I have a few remarks: * %{gem_cache} - For simplification, I would drop it on every OS. It is lightly mentioned just in old guidelines, which are currently aimed on EPEL5, but it makes (almost) no difference if the cache is kept or not. * Shebang change - Although there is no difference in functionality, we are typically doing such changes in %install section. The above remarks are just minor nits and otherwise the package looks sane => APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review