[Bug 1040027] Review Request: double-conversion - Library providing binary-decimal and decimal-binary routines for IEEE doubles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1040027

Orion Poplawski <orion@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |orion@xxxxxxxxxxxxx



--- Comment #1 from Orion Poplawski <orion@xxxxxxxxxxxxx> ---
- rpmbuild -ba --without static_libs double-conversion.spec fails with:

RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/lib64/libdouble-conversion.a
   /usr/lib64/libdouble-conversion_pic.a

- I don't understand the use of %ghost:

%{_libdir}/libdouble-conversion.so.*.*.*
%ghost %{_libdir}/libdouble-conversion.so.2

Normally this is just:

%{_libdir}/libdouble-conversion.so.*

although I recommend:

%{_libdir}/libdouble-conversion.so.2*

to detect soname bumps.

- Drop BuildRoot (unless targeting EPEL 5).

- macro consistency - drop the %{__rm} in clean, just use rm as elsewhere.

- Use %{?dist} in Release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]