Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: queuegraph - A RRDtool frontend for Mail statistics https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233942 ------- Additional Comments From jeremy@xxxxxxxxxxxxxxx 2007-03-26 20:28 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistent macro usage. OK - Meets Packaging Guidelines. ISSUE - License See (1) below OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 2e0c78563cef4fb3195b06e9ee102264 queuegraph.tar.gz 2e0c78563cef4fb3195b06e9ee102264 queuegraph.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. ISSUE - Package owns all the directories it creates. See (2) below OK - rpmlint output E: queuegraph non-standard-gid /var/cache/queuegraph apache E: queuegraph non-standard-dir-perm /var/cache/queuegraph 0775 That should be fine since this is cache location for a cgi script. OK - Should build in mock. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version 1) Only the queugraph.cgi is explicitly GPL the other scripts say nothing about a license and I was unable to find anything on the queuegraph website. Maybe talk to upstream about including a COPYING file ? 2) %dir needed for %{_datadir}/queuegraph -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review