[Bug 974852] Review Request: fish - A Friendly Interactive SHell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=974852



--- Comment #13 from Andy Lutomirski <luto@xxxxxxx> ---
I'm confused about two things:

> - Package contains BR: python2-devel or python3-devel

The only thing I can see that requires python during the build process is
brp-compile-python.  Everything will still work as long as python is present at
runtime even if the .pyc files don't get built.

I added Requires: python, which is indeed needed for the 'config' command to
work.  (I think there's support for Python 3 as an alternative, but it looks
like it would require patching.)

> - Requires missing ncurses

$ rpm -qp --requires fish-2.1.0-1.fc19.x86_64.rpm
[...]
libncurses.so.5()(64bit)

Is that not enough?


Spec: http://web.mit.edu/luto/www/fedora/fish_rpm_v4/fish.spec
SRPM: http://web.mit.edu/luto/www/fedora/fish_rpm_v4/fish-2.1.0-1.fc19.src.rpm

Changes:
 - Bumped the date to today
 - Use %make_install instead of make install DESTDIR=...
 - Removed rm -rf %{buildroot}
 - Added Requires: python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]