[Bug 991400] Review Request: myrulib - E-Book Library Manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=991400

Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vascom2@xxxxxxxxx
              Flags|                            |needinfo?(vascom2@xxxxxxxxx
                   |                            |)



--- Comment #13 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> ---
are you sure that you want to maintain this pkg? Seems like this pkg is SHI~.

if want, you should do:
* Add to F coolreader (crengine subpackage)
* Add to F wxBZipStream
* Add "BuildRequires:  libxml2-devel" to spec
* Add "BuildRequires:  wxsqlite3-devel = 3.0.5" to spec
* %configure options should be
  --without-icu \
  --with-expat \
  --with-reader \
  --without-bzip2 \
  --without-sqlite \
  --without-wxsqlite \
  --without-strip
* Add to %prep section rm -rf 3rdparty/
* Add to %build section autoreconf -vfi
* Apply patch
--- configure.in.orig    2013-09-03 22:30:43.000000000 +0400
+++ configure.in    2013-12-10 22:37:57.274923790 +0400
@@ -197,6 +197,10 @@
     USE_WXSQL="builtin"
 fi

+if test "x$USE_WXSQL" != "xbuiltin" ; then 
+    PKG_CHECK_MODULES(WXSQL, wxsqlite-3.0.5 = 3.0.5, , USE_WXSQL="builtin")
+fi
+
 AC_MSG_CHECKING([for --with-locale])
 AC_ARG_WITH([locale], [AS_HELP_STRING([--with-locale], [Include locale files
into executable])], USE_LOCALE="$withval", USE_LOCALE="no")
 AC_MSG_RESULT([$USE_LOCALE])
@@ -280,7 +284,7 @@
   WX_CXXFLAGS="-I\$(srcdir)/3rdparty/wxsqlite3/include $WX_CXXFLAGS"
   WX_LIBS="-lmrl_wxsqlite3 $WX_LIBS"
 else
-  WX_LIBS="-lwxsqlite3-2.8 $WX_LIBS"
+  WX_LIBS="$WXSQL_LIBS $WX_LIBS"
 fi

 dnl ==================
* Write the same patches for other libs (which have pkgfile) and for sure fix
crengine in configure.in

This is first part.
--------------------------------------------------------------------------------

After this we could continue review ;)

And I ask you again: are you sure want to maintain this SHI~ SHI~ SHI~ pkg

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]