https://bugzilla.redhat.com/show_bug.cgi?id=991621 --- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Will Benton from comment #2) > There are a few issues to correct here: > > Generic: > [!]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > > NB: we CANNOT patch COPYING (as on line 41 of the spec) for legal > reasons; > please leave it as-is. See > > > https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address > > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2 or later) > (with incorrect FSF address)", "Unknown or generated". 27 files have > unknown license. Detailed output of licensecheck in > /home/wibenton/devel/review/991621-remotetea/licensecheck.txt > > The GPL-licensed code is from Classpath, which has a linking exception, > so it's > OK to say the whole package is LGPL-licensed. > > I've reported the address change upstream: > > https://sourceforge.net/apps/trac/remotetea/ticket/2 > > [!]: Package contains no bundled libraries without FPC exception. > > src/org/acplt/oncrpc/apps/jrpcgen/JrpcgenSHA.java is apparently > borrowed from Classpath > is not the same class: * The original file gnu.java.security.provider.SHA.java has been * renamed to reflect the many chances made to it. While the processing * kernel has not been changed, the overall interface has. Especially * some methods have been added which can hash several kinds of data * types, as needed by the jrpcgen protocol compiler. this class has also been removed also from java-gcj-compat, and classpath packages also (dead package) > [!]: Package does not include license text files separate from upstream. > > see above re: patching COPYING > [!]: %check is present and all tests pass. > > There are several testing mains in remotetea/src/tests/; this package > should run them > already run with jrpcgen-test Spec URL: http://gil.fedorapeople.org/remotetea.spec SRPM URL: http://gil.fedorapeople.org/remotetea-1.0.7-2.fc19.src.rpm - fix license field -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review