https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Petr Vobornik <pvoborni@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pvoborni@redhat.c | |om) | --- Comment #2 from Petr Vobornik <pvoborni@xxxxxxxxxx> --- Thank you for the review. Spec and srpm updated: * man page included * %{?_smp_mflags} macro added * simple smoke test added - The only functionality tested is detection of not a font file because it has the most distinctive output. Other use cases are very similar to each other (exit code 0 with no output). Using Buildrequires with font with incorrect fsType is not used because the test will become incorrect when the font is fixed. More comprehensive tests should be implemented upstream and then the %check section should be replaced by simple `make test`. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review