[Bug 990423] Review Request: libsodium - A fork of networking and cryptography library with compatible APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=990423



--- Comment #35 from Jose Pedro Oliveira <jpo@xxxxxxxxxxxx> ---
(In reply to Christopher Meng from comment #28)
> (In reply to Jose Pedro Oliveira from comment #27)
> > (In reply to Christopher Meng from comment #26)
> > > Fixed.
> > > 
> > > -------------------
> > > 
> > > Spec URL: http://cicku.me/libsodium.spec
> > > SRPM URL: http://cicku.me/libsodium-0.4.5-2.fc21.src.rpm
> > 
> > Please add a changelog entry and bump the release.
> 
> I'm not prim and propper. It's just a trivial insertion of install -p, not a
> big change. ...

To be pedantic, theses are the changes you made to the specfile since
2013-11-20:
---------
diff -r -Nup old/libsodium-0.4.5-2.fc21.i686/libsodium.spec
new/libsodium-0.4.5-2.fc21.i686/libsodium.spec
--- old/libsodium-0.4.5-2.fc21.i686/libsodium.spec    2013-11-20
12:43:52.000000000 +0000
+++ new/libsodium-0.4.5-2.fc21.i686/libsodium.spec    2013-12-09
08:24:32.000000000 +0000
@@ -28,11 +28,11 @@ sed -i 's|_pkg_min_version=0.25|_pkg_min
 %endif

 %build
-%configure --disable-static
-make %{?_smp_mflags} V=1
+%configure --disable-static --disable-silent-rules
+make %{?_smp_mflags}

 %install
-make install DESTDIR=%{buildroot}
+make install INSTALL="install -p" DESTDIR=%{buildroot}
 find %{buildroot} -name '*.la' -delete

 %check
----------

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]