[Bug 990423] Review Request: libsodium - A fork of networking and cryptography library with compatible APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=990423



--- Comment #32 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
(In reply to Christopher Meng from comment #28)
> (In reply to Jose Pedro Oliveira from comment #27)
> > (In reply to Christopher Meng from comment #26)
> > > Fixed.
> > > 
> > > -------------------
> > > 
> > > Spec URL: http://cicku.me/libsodium.spec
> > > SRPM URL: http://cicku.me/libsodium-0.4.5-2.fc21.src.rpm
> > 
> > Please add a changelog entry and bump the release.
> 
> I'm not prim and propper. It's just a trivial insertion of install -p, not a
> big change. Why should we waste time here?
To avoid reviewers to look into outdated *.src.rpms containing already fixed
issues.

If you want it more formally: This is a MUST

> Note I usually bump the version, but I don't want to do this this time.  I
> want to speed up the review.
> 
> Hope you can understand.
No, your behavior is unfriendly towards reviewers - You are working sloppy.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]