https://bugzilla.redhat.com/show_bug.cgi?id=1008189 --- Comment #13 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- (In reply to Sandro Mani from comment #12) > Some remarks, full review below: > > - The CFLAGS="%{optflags}" in %configure CFLAGS="%{optflags}" is not > necessary, the %configure macro already includes the CFLAGS, see rpm -E > %configure. Done. > - [!]: Patches link to upstream bugs/comments/lists or are otherwise > justified. => the patch descriptions could be improved > > - Would updating to 2.2.0 RC2 remove some downstream patches? Some have been integrated indeed. I was considering the RC2 on rawhide after a stable version landed in Fedora. > - Non-applied patches: > varnish-agent.src: W: patch-not-applied Patch0: > vagent.secret_privileges.patch > varnish-agent.src: W: patch-not-applied Patch1: vagent.configure.patch > varnish-agent.src: W: patch-not-applied Patch2: vagent.automake.patch > varnish-agent.src: W: patch-not-applied Patch3: vagent.test_suite.patch > varnish-agent.src: W: patch-not-applied Patch4: > vagent.disable_ban_tests.patch False positive, the %autosetup macro applies the patches. Please check the logs of the koji build from comment 11. > Overall, remove the CFLAGS="%{optflags}" and look at the non-applied patches > issue, then I'm happy :) Spec URL: https://bitbucket.org/dridi/fedora_packages/downloads/varnish-agent.spec SRPM URL: https://bitbucket.org/dridi/fedora_packages/downloads/varnish-agent-2.1-5.fc19.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review