https://bugzilla.redhat.com/show_bug.cgi?id=1037899 Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pingou@xxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |pingou@xxxxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> --- Spec is clean * License is clean and is LGPLv2+ * Builds fine on F-19 x86_64 * srpm sources: f44730fc5f25f9425f77b204d9ccbdf209edc4fc fmn.web-0.1.3.tar.gz * upstream sources: f44730fc5f25f9425f77b204d9ccbdf209edc4fc python-fmn-web-0.1.3-1.fc20.src/fmn.web-0.1.3.tar.gz * No bundling seen * rpmlint is almost clean: $ rpmlint python-fmn-web-0.1.3-1.fc20.src.rpm python-fmn-web-0.1.3-1.fc19.noarch.rpm python-fmn-web.src: W: spelling-error Summary(en_US) Frontend -> Fronted, Front end, Front-end python-fmn-web.src: W: spelling-error %description -l en_US fedmsg -> feeding python-fmn-web.src: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end python-fmn-web.noarch: E: explicit-lib-dependency python-fmn-lib python-fmn-web.noarch: E: explicit-lib-dependency python-urllib3 python-fmn-web.noarch: W: spelling-error Summary(en_US) Frontend -> Fronted, Front end, Front-end python-fmn-web.noarch: W: spelling-error %description -l en_US fedmsg -> feeding python-fmn-web.noarch: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end python-fmn-web.noarch: W: non-standard-uid /usr/share/fmn.web/fmn.web.wsgi fmn.web python-fmn-web.noarch: E: script-without-shebang /usr/share/fmn.web/fmn.web.wsgi python-fmn-web.noarch: W: non-standard-uid /usr/share/fmn.web fmn.web python-fmn-web.noarch: W: non-standard-uid /usr/share/fmn.web/static fmn.web python-fmn-web.noarch: E: non-standard-dir-perm /usr/share/fmn.web/static 0644L 2 packages and 0 specfiles checked; 4 errors, 9 warnings. There are a couple of things I do not like here: - the apache configuration file is active - the wsgi file is active I would recommand providing 'sample' file, so basically the same files but with everything commented out. I do not think it is a good idea if people install fmn.web and it starts working w/o any action from them. This might results in security issues of people running web server without having realized it. This would fix 2 of the issues detected by rpmlint. The static content is not changed by the UI, thus I do not think you need to have fmn.web owning the /usr/share/fmn.web directory. If you do, then you probably should create the user properly: http://fedoraproject.org/wiki/Packaging:Guidelines#Users_and_Groups -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review