[Bug 990423] Review Request: libsodium - A fork of networking and cryptography library with compatible APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=990423



--- Comment #24 from Christopher Meng <cickumqt@xxxxxxxxx> ---
(In reply to Igor Gnatenko from comment #21)
> use %make_install instead of make install DESTDIR=%{buildroot}

Inappreciable change IMO, I don't like using macro at here...

> %if 0%{?rhel} == 6
> sed -i 's|_pkg_min_version=0.25|_pkg_min_version=0.23|g' configure
> %endif
> you have plans to support EL6? I don't like to support EL.

Ah, they need this for 0mq...

Igor, hope you can do a full review and then tell us the results.

Thanks!

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]