https://bugzilla.redhat.com/show_bug.cgi?id=1003089 --- Comment #21 from Matthias Runge <mrunge@xxxxxxxxxx> --- Oh yes: why do you use these: %{!?_version:%define _version 1.10.0} %{!?_name:%define _name glusterfs-openstack-swift} %{!?_release:%define _release 1} Please move the definitions to the corresponding place. it makes the whole thing more readable. version, name and release are already variables. - remove rm -rf ... from the clean section https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean - using vendor is unusual - if you have tests, I'd love to see them executed during build. Of course, there is no need to package them. %exclude is the corresponding tag for files section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review