[Bug 1036297] Review Request: libturpial - library needed to new turpial (twitter client) version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1036297



--- Comment #5 from Edwind Richzendy Contreras Soto <richzendy@xxxxxxxxx> ---
(In reply to Eduardo Echeverria from comment #3)
> Hi @Edwin
> 
> - rename the package to turpial-libturpial or python-libturpial.

Done!

> - Remove all el5 stuff (buildroot_tag, %clean, rm -rf after %install.

Done!

> - Add python2-devel or python3-devel as the case may, as BR

Done!

> - The unversioned macro, %{__python} is deprecated. You should use
> %{__python2}

Done!

> - use %build section (You has moved python build in install section, why?)
if i use %build section, and move:


sed -i 's/\.\//share\/doc\/%{name}/' setup.py
%{__python2} setup.py build
%{__python2} setup.py install --root %{buildroot}

>From install section to build section, the rpmbuild fail

> - Change the permissions of the directories and files that are wrong. Do
> that in %install section preferably (Don't use %attr for that, neither
> %defattr)

If i use:

{__chmod} 644 -R %{_buildroot}/doc/%{name}/*

In the %install section, rpmbuild fails

> - Since F20 doc are unversioned please see
> http://fedoraproject.org/wiki/Changes/UnversionedDocdirs.
> - Your package generates unowned directories in the documentation because
> you hasn't marked them as %doc

Done!

> - certs shouldn't go in that place, maybe /etc/pki/$name ?

I need patch the source code to make this, because the path to this cert file
appears in one source file (lib/http.py) and one binary file (lib/http.pyo),
it's fine do it? 

Spec URL: http://repo.richzendy.org/turpial/python-libturpial.spec
SRPM URL:
http://repo.richzendy.org/turpial/python-libturpial-1.0-2.fc19.src.rpm
RPM URL: 
http://repo.richzendy.org/turpial/python-libturpial-1.0-2.fc19.noarch.rpm

#rpmlint rpmbuild/SRPMS/python-libturpial-1.0-2.fc19.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
#rpmlint rpmbuild/RPMS/noarch/python-libturpial-1.0-2.fc19.noarch.rpm
python-libturpial.noarch: W: pem-certificate
/usr/lib/python2.7/site-packages/libturpial/certs/cacert.pem
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Thank you for your time

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]