[Bug 1037897] Review Request: python-fmn-lib - Internal API components and model for Fedora Notifications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1037897



--- Comment #1 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> ---
 Spec is clean
* License is clean and is LGPLv2+
* Builds fine on F-19 x86_64
* Content is clean

* srpm sources:
716a59fd9efa07bb78b9124fa50cfef640c7422a  fmn.lib-0.1.1.tar.gz
* upstream sources:
716a59fd9efa07bb78b9124fa50cfef640c7422a  fmn.lib-0.1.1.tar.gz

* No bundling seen

* rpmlint is almost clean:
$ rpmlint python-fmn-lib-0.1.1-1.fc20.src.rpm
python-fmn-lib-0.1.1-1.fc19.noarch.rpm
python-fmn-lib.src: W: spelling-error %description -l en_US fedmsg -> feeding
python-fmn-lib.noarch: W: spelling-error %description -l en_US fedmsg ->
feeding
python-fmn-lib.noarch: W: no-manual-page-for-binary fmn-createdb
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
And these warnings can be safely ignored

Please note that only the lib/model.py file has a license header, the other
files do not.

The only thing annoying me is that packages do not seem to list a
python-sqlalchemy0.8:
https://apps.fedoraproject.org/packages/s/python-sqlalchemy

Do you plan to ask for an EPEL6 branch? If not then the spec should be
simplified otherwise the Requires and BuildRequires might been to be adjusted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]