[Bug 1010741] Review Request: python-nikola - Static website and blog generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1010741



--- Comment #28 from Christopher Meng <cickumqt@xxxxxxxxx> ---
Sorry, after mock root cleaning up, review process could run well.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "MIT/X11 (BSD like)", "Unknown or generated". 63 files have unknown
     license. Detailed output of licensecheck:


MIT/X11 (BSD like)
------------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/filters.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/main.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/nikola.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugin_categories.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/basic_import.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/auto.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/bootswatch_theme.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/console.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/deploy.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/import_blogger.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/import_feed.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/import_wordpress.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/init.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/install_plugin.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/install_theme.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/new_post.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/planetoid/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/serve.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/version.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/asciidoc.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/bbcode.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/html.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/ipynb/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/markdown/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/markdown/mdx_gist.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/markdown/mdx_nikola.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/markdown/mdx_podcast.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/misaka.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/pandoc.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/php.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/chart.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/doc.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/listing.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/media.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/post_list.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/slides.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/vimeo.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/youtube.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/textile.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/txt2tags.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/wiki.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/loghandler/smtp.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/loghandler/stderr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/archive.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/build_less.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/build_sass.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/bundles.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/copy_assets.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/copy_files.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/galleries.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/gzip.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/indexes.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/listings.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/localsearch/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/mustache/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/pages.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/posts.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/redirect.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/rss.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/sitemap/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/sources.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/task/tags.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/template/jinja.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/template/mako.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/post.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/rc4.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/utils.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/winutils.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/setup.py

Unknown or generated
--------------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/docs/sphinx/conf.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/samplesite/listings/hello.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_bg.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_ca.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_de.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_el.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_en.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_eo.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_es.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_fa.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_fi.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_fr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_hr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_it.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_ja.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_nl.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_pl.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_pt_br.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_ru.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_sl.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_sl_si.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_tr_tr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/base/messages/messages_zh_cn.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_ach.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_bg.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_ca.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_de.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_el.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_en.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_es.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_fa.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_fr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_gr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_hr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_it.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_ja.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_pl.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_pt_br.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_ru.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_tr_tr.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/data/themes/bootstrap3/messages/messages_zh_cn.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/check.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/command/mincss.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/gist.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/nikola/plugins/compile/rest/soundcloud.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/scripts/import_po.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/scripts/set_version.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/base.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/context.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/data/translated_titles/conf.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/import_wordpress_and_build_workflow.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_command_import_wordpress.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_command_init.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_compile_markdown.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_integration.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_locale.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_plugin_importing.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_rss_feeds.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_rst_compiler.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_scheduling.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/nikola-6.2.1/tests/test_utils.py


[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[1]: Package is named according to the Package Naming Guidelines.

------>

%package -n doc
Summary:    Documentation for Nikola, a static site generator
%description -n doc
python-nikola-doc contains detailed usage instructions for Nikola, a static
website and blog generator in python.

You name a package "doc", that's explicitly wrong...

%package doc
Summary:    Documentation for Nikola, a static site generator
%description doc

python-nikola-doc contains detailed usage instructions for Nikola, a static
website and blog generator in python.

Please leave a blank line between %package and %description. Also this
incorrect naming should be fixed in %files.

[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 256000 bytes in 20 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
     nikola-extras , python3-nikola , python3-nikola-extras , doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Installation errors
-------------------
INFO: mock.py version 1.1.35 starting...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Mock Version: 1.1.35
INFO: Mock Version: 1.1.35
Start: lock buildroot
INFO: installing package(s):
/home/rpmaker/Desktop/python-nikola/results/python-nikola-6.2.1-1.fc21.noarch.rpm
/home/rpmaker/Desktop/python-nikola/results/python-nikola-extras-6.2.1-1.fc21.noarch.rpm
/home/rpmaker/Desktop/python-nikola/results/python3-nikola-6.2.1-1.fc21.noarch.rpm
/home/rpmaker/Desktop/python-nikola/results/python3-nikola-extras-6.2.1-1.fc21.noarch.rpm
/home/rpmaker/Desktop/python-nikola/results/doc-6.2.1-1.fc21.noarch.rpm
ERROR: Command failed: 
 # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-i386/root/',
'install',
'/home/rpmaker/Desktop/python-nikola/results/python-nikola-6.2.1-1.fc21.noarch.rpm',
'/home/rpmaker/Desktop/python-nikola/results/python-nikola-extras-6.2.1-1.fc21.noarch.rpm',
'/home/rpmaker/Desktop/python-nikola/results/python3-nikola-6.2.1-1.fc21.noarch.rpm',
'/home/rpmaker/Desktop/python-nikola/results/python3-nikola-extras-6.2.1-1.fc21.noarch.rpm',
'/home/rpmaker/Desktop/python-nikola/results/doc-6.2.1-1.fc21.noarch.rpm',
'--setopt=tsflags=nocontexts']
Error: Package: gstreamer-plugins-base-0.10.36-6.fc21.i686 (fedora)
           Requires: libvisual-0.4.so.0
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest

------> This is caused by libvisual bumping in rawhide, no worries. ;)

Rpmlint
-------
Checking: python-nikola-6.2.1-1.fc21.noarch.rpm
          python-nikola-extras-6.2.1-1.fc21.noarch.rpm
          python3-nikola-6.2.1-1.fc21.noarch.rpm
          python3-nikola-extras-6.2.1-1.fc21.noarch.rpm
          doc-6.2.1-1.fc21.noarch.rpm
          python-nikola-6.2.1-1.fc21.src.rpm
python-nikola.noarch: W: spelling-error %description -l en_US unformatted ->
unformulated, formatted, unfortunate
python-nikola.noarch: W: spelling-error %description -l en_US reStructuredText
-> restructured Text, restructured-text, restructure
python-nikola.noarch: W: no-manual-page-for-binary nikola
python3-nikola.noarch: W: spelling-error %description -l en_US unformatted ->
unformulated, formatted, unfortunate
python3-nikola.noarch: W: spelling-error %description -l en_US reStructuredText
-> restructured Text, restructured-text, restructure

------? I'm not a native English speaker, but I think we can improve it?

doc.noarch: W: spelling-error %description -l en_US nikola -> Nikolai
python-nikola.src: W: spelling-error %description -l en_US unformatted ->
unformulated, formatted, unfortunate
python-nikola.src: W: spelling-error %description -l en_US reStructuredText ->
restructured Text, restructured-text, restructure


python-nikola.src:99: W: mixed-use-of-spaces-and-tabs (spaces: line 99, tab:
line 2)

------> Fix it please.

6 packages and 0 specfiles checked; 0 errors, 9 warnings.




Requires
--------
python3-nikola (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)

--> Verified, Requires: /usr/bin/python3 python(abi) = 3.3, OK.

    python3-PyRSS2Gen
    python3-blinker
    python3-docutils
    python3-doit
    python3-logbook
    python3-lxml
    python3-mako
    python3-pillow
    python3-pygments
    python3-pytz
    python3-unidecode
    python3-yapsy

doc (rpmlib, GLIBC filtered):

python-nikola-extras (rpmlib, GLIBC filtered):
    python-dateutil
    python-jinja2
    python-markdown
    python-mock
    python-nikola
    python-pyphen
    python-requests

python-nikola (rpmlib, GLIBC filtered):
    /usr/bin/python2
    python(abi)

--> Verified, Requires: /usr/bin/python2 python(abi) = 2.7, OK.

    python-PyRSS2Gen
    python-blinker
    python-docutils
    python-doit
    python-logbook
    python-lxml
    python-mako
    python-pillow
    python-pygments
    python-unidecode
    python-yapsy
    pytz

python3-nikola-extras (rpmlib, GLIBC filtered):
    python3-dateutil
    python3-ipython
    python3-jinja2
    python3-markdown
    python3-mock
    python3-nikola
    python3-pyphen
    python3-requests



Provides
--------
python3-nikola:
    python3-nikola

doc:
    doc

---> WRONG!!!

python-nikola-extras:
    python-nikola-extras

python-nikola:
    python-nikola

python3-nikola-extras:
    python3-nikola-extras



Source checksums
----------------
https://github.com/getnikola/nikola/archive/v6.2.1.tar.gz :
  CHECKSUM(SHA256) this package     :
89401d321f769cc35b0a5ca92323d1655f6dedd2e6bd84ec3fc03b464f065691
  CHECKSUM(SHA256) upstream package :
89401d321f769cc35b0a5ca92323d1655f6dedd2e6bd84ec3fc03b464f065691


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -rvn python-nikola-6.2.1-1.fc21.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Python, Shell-api
Disabled plugins: Java, C/C++, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

----------------
Nearly approved!

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]