https://bugzilla.redhat.com/show_bug.cgi?id=1005796 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs? --- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > Issues: > 1. Please do not add a license file which is not upstream. It is enough to > ask upstream to include it. > reported @ http://code.google.com/p/language-detection/issues/detail?id=57 usually we must add license txt file if this one is missing > 2. After the license is added, I'd make langdetect-javadoc co-own > /usr/share/doc/langdetect/LICENSE-2.0.txt to avoid the extra directory with > one file. > ? > 3. suggested %description > langdetect is a language detection library implemented in plain Java. > It uses Bayesian filters generated from language samples retrieved from > Wikipedia to guess the language of text, achieving accuracy above 99%. > Done > + Source URL works, checksum matches. > + Spec file is very nice. > + License is OK. > + No rpmlint output. > + Package follows Java packaging guidelines > > Everything seems OK. Thanks! New Package SCM Request ======================= Package Name: langdetect Short Description: Language Detection Library for Java Owners: gil Branches: f20 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review