https://bugzilla.redhat.com/show_bug.cgi?id=1033967 --- Comment #3 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > Comments: > > 1. please mention *which* shell this program works with. Actually I think > that "bash/sh script static analysis tool" shown by the program is more > informative. New summary: Tool for checking common errors in POSIX shell scripts It can also give you warnings when you use bash-isms with a #!/bin/sh shebang for instance. > 2. I think it would be better to have *one* doc directory, instead of: > /usr/share/doc/ShellCheck > /usr/share/doc/ShellCheck/LICENSE > /usr/share/doc/ShellCheck/README > /usr/share/doc/ghc-ShellCheck > /usr/share/doc/ghc-ShellCheck-devel > /usr/share/doc/ghc-ShellCheck-devel/README > /usr/share/doc/ghc-ShellCheck/LICENSE I didn't touch this part which was generated by cabal-rpm. > with /usr/share/doc/ShellCheck/LICENSE co-owned by other packages if > necessary. Done. > 3. http://www.shellcheck.net/about.html would be better as URL. Done. > Package Review > ============== [snip] > ===== EXTRA items ===== > > Generic: > [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see attached > diff). > See: (this test has no URL) > Some comments are different, it'll be fixed when package is uploaded. This is embarrassing :s [snip] > Rpmlint > ------- > Checking: ShellCheck-0.2.0-2.fc20.x86_64.rpm > ghc-ShellCheck-0.2.0-2.fc20.x86_64.rpm > ghc-ShellCheck-devel-0.2.0-2.fc20.x86_64.rpm > ShellCheck-0.2.0-2.fc20.src.rpm > ShellCheck.x86_64: W: no-manual-page-for-binary shellcheck > Sad but true. Oh well. >From the beginning I intended to ask upstream for a man page and help with the tooling if needed. I expect the man page to appear in a future update :) > ShellCheck.src:11: W: macro-in-comment %{name} > ShellCheck.src:11: W: macro-in-comment %{version} > ShellCheck.src:11: W: macro-in-comment %{name} > ShellCheck.src:11: W: macro-in-comment %{version} > Those could be removed. This was already irrelevant, wrong spec uploaded :s [snip] > Package is APPROVED. > > Please consider fixing minor issues noted at the top. Thank you for the review, I have uploaded the new spec and srpm. Spec URL: https://bitbucket.org/dridi/fedora_packages/downloads/ShellCheck.spec SRPM URL: https://bitbucket.org/dridi/fedora_packages/downloads/ShellCheck-0.2.0-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review